SCons: Change warnings=extra to /W4 for MSVC
#66595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
scons-ci-msvc-enable-W4
branch
from
8705c34 to
9cadedc
Compare
This was referenced Sep 29, 2022
And review and document the set of disabled warnings.
akien-mga
force-pushed
the
scons-ci-msvc-enable-W4
branch
from
9cadedc to
db05059
Compare
|
Superseded by #66808. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And review and document the set of disabled warnings.
Build withwarnings=extraon CI, disablewerror=yesfor now until we have fixed all warnings.Hence this is a draft, should ideally be updated to have
/W4warnings fixed so we can keepwerror=yeson CI.Part of #66537.