Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel perfect font no longer rendering properly in Godot 4.3 #91010

Closed
unlessgames opened this issue Apr 22, 2024 · 4 comments · Fixed by #91931
Closed

Pixel perfect font no longer rendering properly in Godot 4.3 #91010

unlessgames opened this issue Apr 22, 2024 · 4 comments · Fixed by #91931
Assignees
Milestone

Comments

@unlessgames
Copy link

unlessgames commented Apr 22, 2024

Tested versions

Godot v4.3.dev (7529c0b)

System information

Linux with X11

Issue description

Before version 4.3 I was able to use Terminus TTF font in the editor and it would show up nicely. In 4.3 the font looks either blurry or the pixels show up at the wrong spots. Both the Editor Inteface and the built-in code editor is affected.

Below is an image that shows the correct font rendering from 4.2 on the left and the messed up one from 4.3 on the right (with two different antialiasing options). I couldn't make the font look good with any settings.

Make sure you view the image at the exact resolution to properly see the issues.

godot4 3dev5_font

Steps to reproduce

  • Get the terminus font
  • Have editor ui scaling at 100% and 1
  • Set editor the to use the font as Main Font
  • Play with settings to see the issue persist

Minimal reproduction project (MRP)

The problem is not project specific.

@unlessgames unlessgames changed the title Pixel perfect font no longer rendering properly in Godot 4.3 Pixel perfect font no longer rendering properly as Editor Main font in Godot 4.3 Apr 22, 2024
@unlessgames unlessgames changed the title Pixel perfect font no longer rendering properly as Editor Main font in Godot 4.3 Pixel perfect font no longer rendering properly in Godot 4.3 Apr 22, 2024
@clayjohn clayjohn added this to the 4.3 milestone May 2, 2024
@bruvzg bruvzg self-assigned this May 14, 2024
@bruvzg
Copy link
Member

bruvzg commented May 14, 2024

Might be related to addition of disable_embedded_bitmaps property (a lot of fonts seems to have broken embedded bitmaps), which is enabled by default, I guess we should expose it as an editor setting.

@unlessgames
Copy link
Author

unlessgames commented May 14, 2024

Thank you for the fix @bruvzg, it looks good now!

Could you share some info about what is broken with embedded bitmaps and how they should be instead? I might forward it to the creator of this font, I am sure they would want to improve it if the issues are clear!

@bruvzg
Copy link
Member

bruvzg commented May 14, 2024

Bitmaps in the terminus font seems fine. #89374 (comment) is an example of broken font (a lot of missing and mixed up characters in the bitmap), I have seen similar issues with some fonts as well, but do not remember exact names.

@unlessgames
Copy link
Author

Ah ok, I didn't realize the double negative with this setting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
4 participants