Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a cursor column check. #10653

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Conversation

tuga3d
Copy link
Contributor

@tuga3d tuga3d commented Aug 26, 2017

Fixes glitch, when cursor is on column 0 of and indented line and you press return an extra indent is added.

@ghost
Copy link

ghost commented Aug 26, 2017

Thanks for contributing! Please use tabs for indentation. You can use git commit --amend for the changes according to this PR workflow.

Fixes glich, when cursor is on column 0 of and indented line and you
press return an extra indent is added.
@tuga3d
Copy link
Contributor Author

tuga3d commented Aug 26, 2017

Done. Sorry, should have checked this.

@akien-mga akien-mga merged commit fe26bcd into godotengine:master Aug 27, 2017
tuga3d added a commit to tuga3d/godot that referenced this pull request Aug 30, 2017
I've reverted the first attempt (godotengine#10653).
I was very naive and didn't consider that the glitch happens also if you're not in the first column, ex. if you have 2 tabs and press return in between them.
Hope this will solve the problem without messing anything else.
@tuga3d tuga3d deleted the indent-glitch branch September 6, 2017 18:04
@tuga3d tuga3d restored the indent-glitch branch September 6, 2017 18:04
@tuga3d tuga3d deleted the indent-glitch branch September 6, 2017 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants