Track LightInstance::shadow_atlases so that it will be freed properly #11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the issues #11848 (the second issuse (endless error message on scene change) of two issues reported there) and its duplicate #10346.
My observation on this issue is as follows.
LightInstance::shadow_atlasesis supposed to be freed fromRasterizerSceneGLES3::free(RID p_rid), but currently it turns out nothing is added to theSetdata structurelight_instance->shadow_atlases. So what I changed in this commit is addinglight_instance->shadow_atlases.insert(...)where it seems appropriate, which is after successfulRasterizerSceneGLES3::_shadow_atlas_find_shadow.