Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug when setting projection matrix in shader GLES2 #27798

Merged
merged 1 commit into from May 13, 2019

Conversation

@clayjohn
Copy link
Contributor

clayjohn commented Apr 8, 2019

Fixes: #23185

Mirrors the behaviour in GLES3, allows users to write directly to projection matrix.

Note: I also made INV_PROJECTION_MATRIX a const. It doesn't make sense to be able to write to this, plus if anyone actually did it would've caused a bug in both GLES2 and GLES3 currently. So clearly no one is doing this. I will update the docs accordingly once this is merged.

@clayjohn clayjohn requested a review from reduz as a code owner Apr 8, 2019
@Chaosus Chaosus added this to the 3.2 milestone Apr 8, 2019
@clayjohn clayjohn force-pushed the clayjohn:gles2-proj-mat-bug branch from 9838599 to e37d723 Apr 30, 2019
@akien-mga akien-mga merged commit 86a74e2 into godotengine:master May 13, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented May 13, 2019

Thanks!

@clayjohn clayjohn deleted the clayjohn:gles2-proj-mat-bug branch Jul 8, 2019
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Jul 17, 2019

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.