Fixes bug when setting projection matrix in shader GLES2 #27798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
force-pushed
the
gles2-proj-mat-bug
branch
from
9838599
to
e37d723
Compare
|
Thanks! |
|
Cherry-picked for 3.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23185
Mirrors the behaviour in GLES3, allows users to write directly to projection matrix.
Note: I also made
INV_PROJECTION_MATRIXa const. It doesn't make sense to be able to write to this, plus if anyone actually did it would've caused a bug in both GLES2 and GLES3 currently. So clearly no one is doing this. I will update the docs accordingly once this is merged.