Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GLES2 transparency order #28520

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@clayjohn
Copy link
Contributor

clayjohn commented Apr 29, 2019

GLES2 was using sort_by_depth but GLES3 uses SortByReverseDepthAndPriority. Now using alpha no longer makes objects render out of order.

Code comes directly out of the GLES3 backend.

This may also restore render priority to GLES2, but I haven't looked into that in depth yet.

Fixes: #27141

@clayjohn clayjohn requested a review from reduz Apr 29, 2019
@akien-mga akien-mga added this to the 3.2 milestone Apr 29, 2019
@akien-mga akien-mga merged commit a5c619d into godotengine:master Apr 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Apr 30, 2019

Thanks!

@clayjohn

This comment has been minimized.

Copy link
Contributor Author

clayjohn commented May 22, 2019

@akien-mga this should be cherrypicked for 3.1.2!

@Tobi-La

This comment has been minimized.

Copy link

Tobi-La commented Jun 2, 2019

@akien-mga Cherrypick is still missing if I didn't miss something, am I right? I would be very thankful if this would make it to 3.1.2, as I really need this fix for my project and the current master build has some other issues.

@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Jun 2, 2019

The label is there, the rest is up to release managers.

georgewsinger added a commit to SimulaVR/godot that referenced this pull request Jun 12, 2019
- See godotengine#27141
- See also godotengine#28520
  - The code in this commit is (manually) cherry-picked from this.
@clayjohn clayjohn deleted the clayjohn:GLES2-alpha-draw-order branch Jul 7, 2019
@akien-mga

This comment has been minimized.

Copy link
Member

akien-mga commented Jul 17, 2019

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.