Fixed GLES2 transparency order #28520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@akien-mga this should be cherrypicked for 3.1.2! |
This was referenced May 27, 2019
|
@akien-mga Cherrypick is still missing if I didn't miss something, am I right? I would be very thankful if this would make it to 3.1.2, as I really need this fix for my project and the current master build has some other issues. |
|
The label is there, the rest is up to release managers. |
georgewsinger
added a commit
to SimulaVR/godot
that referenced
this pull request
Jun 12, 2019
- See godotengine#27141 - See also godotengine#28520 - The code in this commit is (manually) cherry-picked from this.
|
Cherry-picked for 3.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLES2 was using
sort_by_depthbut GLES3 usesSortByReverseDepthAndPriority. Now using alpha no longer makes objects render out of order.Code comes directly out of the GLES3 backend.
This may also restore render priority to GLES2, but I haven't looked into that in depth yet.
Fixes: #27141