Adding Motion Matching Library #29892

Aa20475 · 2019-06-19T08:48:44Z

Basic Structure of Node and tree made

TODO: Build tree

guilhermefelipecgs · 2019-06-25T16:35:05Z

modules/motionmatch/animation_motion_match_editor.cpp

+#include "core/io/resource_loader.h"
+
+bool AnimationNodeMotionMatchEditor::can_edit(
+    const Ref<AnimationNode> &p_node) {


Just a note, in the cpp files, we use <tab> instead of <space> for indentation.

I actually set up the pre-commit-hook too. Will recheck it..

fire · 2019-07-04T04:57:34Z

Remember that the red crosses are the travis and appveyor ci checks failing. These are test compiles of the project.

Aa20475 · 2019-07-10T04:45:28Z

Remember that the red crosses are the travis and appveyor ci checks failing. These are test compiles of the project.

Ohh! I really am not sure why they fail... :(
Help me with it please.....

fire · 2019-07-10T06:13:26Z

Clang format.
Here's an error log.

modules/motionmatch/animation_motion_match_editor.cpp: In member function 'void AnimationNodeMotionMatchEditor::_update_tracks()':
modules/motionmatch/animation_motion_match_editor.cpp:267:44: error: passing NULL to non-pointer argument 1 of 'Variant::Variant(int64_t)' [-Werror=conversion-null]
  267 |                           .get("location", NULL));
      |                                            ^~~~
In file included from ./core/method_ptrcall.h:36,
                 from ./core/method_bind.h:35,
                 from ./core/class_db.h:34,
                 from ./scene/main/node.h:34,
                 from ./editor/audio_stream_preview.h:35,
                 from ./editor/editor_node.h:35,
                 from ./editor/plugins/animation_tree_editor_plugin.h:34,
                 from modules/motionmatch/animation_motion_match_editor.h:6,
                 from modules/motionmatch/animation_motion_match_editor.cpp:1:
./core/variant.h:251:18: note:   declared here
  251 |  Variant(int64_t p_int); // real one
      |          ~~~~~~~~^~~~~
g++-9 -o modules/motionmatch/animation_node_motion_match.x11.tools.64.o -c -Wctor-dtor-privacy -Wnon-virtual-dtor -Wnoexcept -Wplacement-new=1 -g3 -pipe -fpie -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wshadow-local -Walloc-zero -Wduplicated-branches -Wduplicated-cond -Wstringop-overflow=4 -Wlogical-op -Wattribute-alias=2 -Werror -DDEBUG_ENABLED -DDEBUG_MEMORY_ENABLED -DTOUCH_ENABLED -DALSA_ENABLED -DALSAMIDI_ENABLED -DJOYDEV_ENABLED -DX11_ENABLED -DUNIX_ENABLED -DOPENGL_ENABLED -DGLES_ENABLED -DZSTD_STATIC_LINKING_ONLY -DGLAD_ENABLED -DGLES_OVER_GL -DMODULE_ASSIMP_ENABLED -DMODULE_BMP_ENABLED -DMODULE_BULLET_ENABLED -DMODULE_CSG_ENABLED -DMODULE_CVTT_ENABLED -DMODULE_DDS_ENABLED -DMODULE_ENET_ENABLED -DMODULE_ETC_ENABLED -DMODULE_FREETYPE_ENABLED -DMODULE_GDNATIVE_ENABLED -DMODULE_GDSCRIPT_ENABLED -DMODULE_GRIDMAP_ENABLED -DMODULE_HDR_ENABLED -DMODULE_JPG_ENABLED -DMODULE_MBEDTLS_ENABLED -DMODULE_MOBILE_VR_ENABLED -DMODULE_MONO_ENABLED -DMODULE_MOTIONMATCH_ENABLED -DDEBUG_MEMORY_ALLOC -DDISABLE_FORCED_INLINE -DPTRCALL_ENABLED -DTOOLS_ENABLED -DGDSCRIPT_ENABLED -DMINIZIP_ENABLED -Ithirdparty/libpng -Ithirdparty/glad -Ithirdparty/zstd -Ithirdparty/zlib -Iplatform/x11 -I. -Ieditor modules/motionmatch/animation_node_motion_match.cpp
cc1plus: all warnings being treated as errors
scons: *** [modules/motionmatch/animation_motion_match_editor.x11.tools.64.o] Error 1
modules/motionmatch/animation_node_motion_match.cpp: In member function 'void AnimationNodeMotionMatch::add_coordinates(PoolRealArray)':
modules/motionmatch/animation_node_motion_match.cpp:112:20: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  112 |   if (point.size() != dim_len) {
      |       ~~~~~~~~~~~~~^~~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp: In member function 'void AnimationNodeMotionMatch::load_coordinates(PoolRealArray)':
modules/motionmatch/animation_node_motion_match.cpp:130:23: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  130 |     for (int i = 0; i < points.size() / dim_len; i++) {
      |                     ~~^~~~~~~~~~~~~~~~~~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp:132:25: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  132 |       for (int j = 0; j < dim_len; j++) {
      |                       ~~^~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp: In member function 'void AnimationNodeMotionMatch::clear_root()':
modules/motionmatch/animation_node_motion_match.cpp:162:16: error: ambiguous overload for 'operator=' (operand types are 'Ref<AnimationNodeMotionMatch::KDNode>' and 'std::nullptr_t')
  162 |   root->left = nullptr;
      |                ^~~~~~~
In file included from ./core/io/stream_peer.h:34,
                 from ./core/io/packet_peer.h:34,
                 from ./core/io/networked_multiplayer_peer.h:34,
                 from ./core/io/multiplayer_api.h:34,
                 from ./core/script_language.h:34,
                 from ./scene/main/node.h:39,
                 from ./scene/3d/spatial.h:34,
                 from ./scene/3d/collision_object.h:34,
                 from ./scene/3d/physics_body.h:35,
                 from modules/motionmatch/animation_node_motion_match.h:4,
                 from modules/motionmatch/animation_node_motion_match.cpp:1:
./core/reference.h:152:7: note: candidate: 'void Ref<T>::operator=(const Ref<T>&) [with T = AnimationNodeMotionMatch::KDNode]'
  152 |  void operator=(const Ref &p_from) {
      |       ^~~~~~~~
./core/reference.h:185:7: note: candidate: 'void Ref<T>::operator=(const Variant&) [with T = AnimationNodeMotionMatch::KDNode]'
  185 |  void operator=(const Variant &p_variant) {
      |       ^~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp:163:17: error: ambiguous overload for 'operator=' (operand types are 'Ref<AnimationNodeMotionMatch::KDNode>' and 'std::nullptr_t')
  163 |   root->right = nullptr;
      |                 ^~~~~~~
In file included from ./core/io/stream_peer.h:34,
                 from ./core/io/packet_peer.h:34,
                 from ./core/io/networked_multiplayer_peer.h:34,
                 from ./core/io/multiplayer_api.h:34,
                 from ./core/script_language.h:34,
                 from ./scene/main/node.h:39,
                 from ./scene/3d/spatial.h:34,
                 from ./scene/3d/collision_object.h:34,
                 from ./scene/3d/physics_body.h:35,
                 from modules/motionmatch/animation_node_motion_match.h:4,
                 from modules/motionmatch/animation_node_motion_match.cpp:1:
./core/reference.h:152:7: note: candidate: 'void Ref<T>::operator=(const Ref<T>&) [with T = AnimationNodeMotionMatch::KDNode]'
  152 |  void operator=(const Ref &p_from) {
      |       ^~~~~~~~
./core/reference.h:185:7: note: candidate: 'void Ref<T>::operator=(const Variant&) [with T = AnimationNodeMotionMatch::KDNode]'
  185 |  void operator=(const Variant &p_variant) {
      |       ^~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp: In member function 'void AnimationNodeMotionMatch::build_tree()':
modules/motionmatch/animation_node_motion_match.cpp:194:18: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
  194 |     else if (err = K_ERROR)
      |              ~~~~^~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp: In member function 'PoolRealArray AnimationNodeMotionMatch::KNNSearch(PoolRealArray, uint32_t)':
modules/motionmatch/animation_node_motion_match.cpp:237:18: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
  237 |     else if (err = K_ERROR)
      |              ~~~~^~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp:247:39: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  247 |     while (node->get_indices().size() > min_leaves) {
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp:255:23: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  255 |     for (int j = 0; j < k; j++) {
      |                     ~~^~~
modules/motionmatch/animation_node_motion_match.cpp: In member function 'bool AnimationNodeMotionMatch::KDNode::are_all_points_same(PoolRealArray, uint32_t)':
modules/motionmatch/animation_node_motion_match.cpp:324:21: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  324 |   for (int i = 0; i < dim_len; i++) {
      |                   ~~^~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp: In member function 'void AnimationNodeMotionMatch::KDNode::leaf_split(PoolRealArray, uint32_t, uint32_t, uint32_t)':
modules/motionmatch/animation_node_motion_match.cpp:383:36: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  383 |     if (left->point_indices.size() > min_leaves &&
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
modules/motionmatch/animation_node_motion_match.cpp:387:37: error: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
  387 |     if (right->point_indices.size() > min_leaves &&
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
cc1plus: all warnings being treated as errors
scons: *** [modules/motionmatch/animation_node_motion_match.x11.tools.64.o] Error 1
scons: building terminated because of errors.
The command "if [ "$STATIC_CHECKS" = "yes" ]; then sh ./misc/travis/clang-format.sh; else scons -j2 CC=$CC CXX=$CXX platform=$PLATFORM tools=$TOOLS target=$TARGET $OPTIONS $EXTRA_ARGS; fi" exited with 2.```

fire · 2019-09-28T05:58:00Z

You can use clang-format -i *.cpp and clang-format -i *.h to format your source files to the Godot style standard.

Rebasing in git allows you to put the branch on top of the current git 3.2 master.

It also allows you to squash multiple commits together for clarity.

Aa20475 · 2019-09-28T14:27:27Z

Okay thanks!

aaronfranke · 2020-05-26T20:11:19Z

@Aa20475 Is this still desired? If so, it needs to be rebased on the latest master branch, and squashed, as per this article. Also, since this PR is a feature proposal, you should consider opening a proposal which explains example use cases and how this approach will solve the problem.

Otherwise, abandoned pull requests will be closed in the future as announced here.

Aa20475 · 2020-05-26T21:00:10Z

Okay will do it asap. I'd still love to work on this PR. ✌️

fire · 2020-05-26T21:09:28Z

#32408 is my rebased pr, feel free to take it.

Aa20475 · 2020-05-26T23:18:59Z

That's cool! Can you give me a short desc of the changes you made , so that i can catch up?

fire · 2020-05-26T23:27:19Z

Fixed compiler errors.
Was not able to correct the cost and trajectory predictions.
Changed some code from whatever to int. I believe int64 is the default for size now. Not sure.
CICD errors are fixed then, but I don't have any test cases
CICD errors on master

Note: Edited

Aa20475 · 2020-05-27T00:57:25Z

Ohh okay! That's cool!

I've been exploring about it too. We still need to speed up the kdtrees knnsearch in some way. I thought we can implement it to run of GPU.

There is a more complex and sophisticated algorithm which adds reinforcement learning to this which is the actual algorithm in the paper that proposed motion fields.

But I thought speeding up the KNNsearch takes the first priority.

Also, any luck with running it during game preview?

fire · 2020-05-27T01:06:46Z

Can you create a test project?

…e cost and trajectory predictions..

…t...

Aa20475 · 2020-09-10T10:10:08Z

I thought I had it somewhere on my Hard disk. I'll find it or make a new one asap!

Aa20475 · 2020-09-10T11:05:42Z

Thanks a lot, @fire for doing the changes. I will make a test project quick and let you know.

fire · 2020-11-14T16:15:50Z

Can you post the design document for the GSOC, so I can make a proposal for this?

aaronfranke · 2021-01-20T06:40:06Z

@Aa20475 This PR doesn't build, please fix it and squash the commits. See this article for more information.

fire · 2024-02-12T17:32:11Z

This is an incomplete motion matching implementation. A more recent version is from https://github.com/Remi123/MotionMatching. I would like to archive this pull request.

groud added feature proposal topic:core labels Jun 19, 2019

akien-mga added this to the 3.2 milestone Jun 20, 2019

guilhermefelipecgs reviewed Jun 25, 2019

View reviewed changes

Aa20475 force-pushed the godot-motion-matching branch from 4ebf094 to a5155a1 Compare July 31, 2019 16:10

fire mentioned this pull request Sep 28, 2019

[WIP] Add animation motion-matching #32408

Closed

akien-mga modified the milestones: 3.2, 4.0 Nov 7, 2019

Aa20475 added 8 commits September 10, 2020 15:17

Testing

909469b

Testing: Trying to fix pre_choice resetting everytime

88a3830

Testing

4f01425

Finally, Frame choosing behavior workinggit add . TODO: Correcting th…

5706c3c

…e cost and trajectory predictions..

Added appropriate Comments.. Improved matching... Small errors persis…

cc9b563

…t...

Test

e9b0480

Improved UI and better matching. UNABLE TO SEE CHANGES IN SCREEN

936c9ac

Update

cd78661

Clang-format

4e0a498

Aa20475 force-pushed the godot-motion-matching branch from 48b1712 to 4e0a498 Compare September 10, 2020 10:19

Changes by Fire

1dc698d

Aa20475 added 2 commits September 10, 2020 16:37

Changes by Fire p2

457b357

Build fail fixes

090f734

YuriSizov added the topic:animation label Aug 25, 2021

YuriSizov requested review from a team August 25, 2021 22:50

fire mentioned this pull request Jan 20, 2023

Implement Motion Matching godotengine/godot-proposals#6122

Open

YuriSizov modified the milestones: 4.0, 4.x Feb 12, 2023

GeorgeS2019 mentioned this pull request Mar 31, 2023

Godot4 Motion Matching GeorgeS2019/Godot4-3D-IK-Demo#2

Open

AThousandShips added the needs work label Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Motion Matching Library #29892

Adding Motion Matching Library #29892

Aa20475 commented Jun 19, 2019

guilhermefelipecgs Jun 25, 2019

Aa20475 Jun 25, 2019

guilhermefelipecgs Jun 25, 2019

fire commented Jul 4, 2019 •

edited

Aa20475 commented Jul 10, 2019

fire commented Jul 10, 2019

fire commented Sep 28, 2019 •

edited

Aa20475 commented Sep 28, 2019

aaronfranke commented May 26, 2020

Aa20475 commented May 26, 2020

fire commented May 26, 2020

Aa20475 commented May 26, 2020

fire commented May 26, 2020 •

edited

Aa20475 commented May 27, 2020

fire commented May 27, 2020

Aa20475 commented Sep 10, 2020

Aa20475 commented Sep 10, 2020

fire commented Nov 14, 2020

aaronfranke commented Jan 20, 2021

fire commented Feb 12, 2024

Adding Motion Matching Library #29892

Are you sure you want to change the base?

Adding Motion Matching Library #29892

Conversation

Aa20475 commented Jun 19, 2019

guilhermefelipecgs Jun 25, 2019

Choose a reason for hiding this comment

Aa20475 Jun 25, 2019

Choose a reason for hiding this comment

guilhermefelipecgs Jun 25, 2019

Choose a reason for hiding this comment

fire commented Jul 4, 2019 • edited

Aa20475 commented Jul 10, 2019

fire commented Jul 10, 2019

fire commented Sep 28, 2019 • edited

Aa20475 commented Sep 28, 2019

aaronfranke commented May 26, 2020

Aa20475 commented May 26, 2020

fire commented May 26, 2020

Aa20475 commented May 26, 2020

fire commented May 26, 2020 • edited

Aa20475 commented May 27, 2020

fire commented May 27, 2020

Aa20475 commented Sep 10, 2020

Aa20475 commented Sep 10, 2020

fire commented Nov 14, 2020

aaronfranke commented Jan 20, 2021

fire commented Feb 12, 2024

fire commented Jul 4, 2019 •

edited

fire commented Sep 28, 2019 •

edited

fire commented May 26, 2020 •

edited