Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature: Add SHA256 for PoolByteArray" #31560

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Aug 22, 2019

This reverts commit e2c3bba from #24269.

This was superseded by #29871 which adds more crypto features with a
dedicated interface.

Since this commit was never in a stable release (merged during 3.2 dev),
we revert it to avoid having to deprecate it in favor of the HashingContext API.
See #31187 (comment)

@xsellier FYI

This reverts commit e2c3bba.

This was superseded by godotengine#29871 which adds more crypto features with a
dedicated interface.

Since this commit was never in a stable release (merged during 3.2 dev),
we revert it to avoid having to deprecate it in favor of the Crypto API.
See godotengine#31187 (comment)
@akien-mga
Copy link
Member Author

Example from #29871:

extends Node

func _ready():
	var ctx = HashingContext.new()
	ctx.start(HashingContext.HASH_SHA256) # Or HASH_SHA1 or HASH_MD5
	print("a".to_utf8().size()) # 1
	ctx.update("a".to_ascii())
	var fin = ctx.finish()
	print(Array(fin)) # [202, 151, 129, 18, 202, 27, 189, 202, 250, 194, 49, 179, 154, 35, 220, 77, 167, 134, 239, 248, 20, 124, 78, 114, 185, 128, 119, 133, 175, 238, 72, 187]
	print(fin.hex_encode()) # ca978112ca1bbdcafac231b39a23dc4da786eff8147c4e72b9807785afee48bb

@akien-mga akien-mga merged commit abd13e4 into godotengine:master Aug 22, 2019
@akien-mga akien-mga deleted the revert-24269-sha256string branch August 22, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant