Activate emscripten with no-embedded option. #39168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
the
cherrypick:3.x
akien-mga
approved these changes
May 30, 2020
|
Thanks! |
|
Removing |
akien-mga
removed
the
cherrypick:3.x
|
This is no longer valid, latest emscripten removed the CC @Faless |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 21, 2020
1.39.20 dropped support for the no-embedded mode we use since godotengine#39168, as our detection logic hasn't been fixed yet to support the embedded mode.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 21, 2020
Reverts and supersedes godotengine#39168 and godotengine#40563.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 31, 2020
Emscripten is a fast-moving target which gets tons of improvements all the time, but it's not rare that some regressions affect us and make our CI builds fail. (See e.g. godotengine#33728, godotengine#35237, godotengine#39168, godotengine#40563, and godotengine#40914.) Let's pin to a stable version to avoid having external factors impact our CI, and update this version manually regularly in a PR to ensure that the new version works well for us.
MarcusElg
pushed a commit
to MarcusElg/godot
that referenced
this pull request
Oct 19, 2020
1.39.20 dropped support for the no-embedded mode we use since godotengine#39168, as our detection logic hasn't been fixed yet to support the embedded mode.
MarcusElg
pushed a commit
to MarcusElg/godot
that referenced
this pull request
Oct 19, 2020
Reverts and supersedes godotengine#39168 and godotengine#40563.
MarcusElg
pushed a commit
to MarcusElg/godot
that referenced
this pull request
Oct 19, 2020
Emscripten is a fast-moving target which gets tons of improvements all the time, but it's not rare that some regressions affect us and make our CI builds fail. (See e.g. godotengine#33728, godotengine#35237, godotengine#39168, godotengine#40563, and godotengine#40914.) Let's pin to a stable version to avoid having external factors impact our CI, and update this version manually regularly in a PR to ensure that the new version works well for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript's Travis CI is failing because javascript's
can_build()is returningfalse:godot/platform/javascript/detect.py
Lines 14 to 15 in 0f1da72
Emscripten is moving to an embedded config model:
emscripten-core/emscripten#9543
The activate option was changed to --embedded by default:
emscripten-core/emsdk#472
So this is a quick fix to mirror their own quick fix:
emscripten-core/emscripten#11293
Basically, we need to use --no-embedded until we can update our own check for a properly installed Emscripten.