Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Complex Text Layouts] Add compatibility for legacy Font resources. #43931

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 28, 2020

Depends on #42595 and #43030

Add support for loading scenes with BitmapFonts and DynamicFonts. All relevant code is inside #ifndef DISABLE_DEPRECATED blocks.

TODO:

  • Scene loads successfully.
  • DynamicFonts are converted to Font.
  • BitmapFont s are converted to Font.

Added extra check to ClassDB::_is_parent_class, to prevent error spam for other resource loaders.

@bruvzg bruvzg added this to the 4.0 milestone Nov 28, 2020
@bruvzg bruvzg force-pushed the ctl_comp_font branch 3 times, most recently from 43ac974 to f649118 Compare December 3, 2020 08:29
@bruvzg bruvzg changed the title [Complex Text Layouts, WIP] Add compatibility for legacy Font resources. [Complex Text Layouts] Add compatibility for legacy Font resources. Dec 3, 2020
@bruvzg bruvzg marked this pull request as ready for review December 3, 2020 08:37
@akien-mga akien-mga merged commit 92c001e into godotengine:master Dec 9, 2020
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the ctl_comp_font branch December 9, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants