Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Complex Text Layouts] Refactor RichTextLabel. #42595

Merged
merged 1 commit into from
Dec 13, 2020
Merged

[Complex Text Layouts] Refactor RichTextLabel. #42595

merged 1 commit into from
Dec 13, 2020

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 6, 2020 •
edited
Loading

Part of godotengine/godot-proposals#1180 implementation.

Depends on #41100 #43981

  • BBCode.
    • Add font size tag / features tag. ✔️
    • Add layout control tags. ✔️
    • Add structured text control tags. ✔️
  • RTL content shaping / cache. ✔️
    • Text handling. ✔️
    • Table handling. ✔️
    • List handling. ✔️
  • RTL content draw. ✔️
    • Text drawing. ✔️
    • Table drawing. ✔️
    • List drawing (ul, ol (types = 1,a,A,i,I), including nested lists). ✔️
  • Hit test / carets / selection / search. ✔️
  • Optimize cache search and invalidation. ✔️
  • UI mirroring. ✔️
    • RTL internals mirroring. ✔️
    • Set BiDi overrides for editor UI RTL controls. ✔️

Test Project: RTL.zip

Screenshots

RTL

@bruvzg bruvzg added this to the 4.0 milestone Oct 6, 2020
@bruvzg bruvzg force-pushed the ctl_rich_text branch 14 times, most recently from c17e996 to ede83af Compare October 13, 2020 13:47
@bruvzg bruvzg force-pushed the ctl_rich_text branch 9 times, most recently from 6e59cfc to 4fd0489 Compare October 22, 2020 07:57
@bruvzg bruvzg force-pushed the ctl_rich_text branch 2 times, most recently from cb96e24 to fd332c7 Compare October 22, 2020 16:46
@bruvzg bruvzg mentioned this pull request Nov 28, 2020
Merged
3 tasks
@bruvzg bruvzg force-pushed the ctl_rich_text branch 6 times, most recently from 7fe2ca2 to ae66478 Compare December 2, 2020 21:20
@akien-mga akien-mga mentioned this pull request Dec 4, 2020
Merged
@bruvzg bruvzg force-pushed the ctl_rich_text branch 3 times, most recently from 9d9451e to b484d02 Compare December 7, 2020 10:11
@bruvzg bruvzg mentioned this pull request Dec 11, 2020
Merged
Paulb23
Paulb23 approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@Paulb23 Paulb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akien-mga
Copy link
Member

@reduz also approved on IRC, so let's merge.

@akien-mga akien-mga merged commit bbf7bb3 into godotengine:master Dec 13, 2020
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the ctl_rich_text branch December 13, 2020 12:44
@HaSa1002 HaSa1002 mentioned this pull request Dec 13, 2020
Closed
This was referenced Dec 14, 2020
Closed
Closed
Closed
Closed
@madmiraal madmiraal mentioned this pull request Dec 15, 2020
Merged
This was referenced Jan 8, 2021
Closed
Closed
@NoFr1ends NoFr1ends mentioned this pull request May 28, 2021
Merged
@rsubtil rsubtil mentioned this pull request Sep 6, 2021
Closed
@DeeJayLSP DeeJayLSP mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulb23 Paulb23 Paulb23 approved these changes

@akien-mga akien-mga Awaiting requested review from akien-mga

@neikeq neikeq Awaiting requested review from neikeq

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
breaks compat enhancement topic:editor topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @Paulb23