Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CONNECT_REFERENCE_COUNTED #47442

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Fix CONNECT_REFERENCE_COUNTED #47442

merged 1 commit into from
Oct 1, 2021

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Mar 28, 2021 •
edited
Loading

CONNECT_REFERENCE_COUNTED requires 1 more disconnect call than connect calls. The PR fixes this behavior.

Minimal reproduction project:

TestConnect.zip

(just try to uncomment line 14)

Closes #44584.

@Shatur Shatur requested a review from a team as a code owner March 28, 2021 17:04
@Calinou Calinou added this to the 4.0 milestone Mar 28, 2021
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 28, 2021
theraot
theraot approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@theraot theraot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vow that:

  • The bug being fixed still happens at the time of writing
  • This change fixes the bug
  • The change makes sense

I had a look at every use of CONNECT_REFERENCE_COUNTED in master, and I believe this change will not introduce new problems.

@akien-mga akien-mga merged commit 01cb4d9 into godotengine:master Oct 1, 2021
@akien-mga
Copy link
Member

Thanks!

@Shatur Shatur deleted the fix-connect-reference-counted branch October 1, 2021 21:05
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theraot theraot theraot approved these changes

@reduz reduz reduz approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

CONNECT_REFERENCE_COUNTED requires two disconnects for a single connect
5 participants
@Shatur @akien-mga @theraot @reduz @Calinou