Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LineEdit getters and setters to match property names #47448

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

madmiraal
Copy link
Contributor

@madmiraal madmiraal commented Mar 29, 2021

Part of #16863.

As originally identified by @AlexHolly in #16116, LineEdit's caret_* properties getters and setters are misnamed. This PR renames those getters and setters to match the property names. In addition, for consistency, it renames a few other methods and the documentation to refer to caret instead of cursor too.

Methods renamed:

Old Property New Property Old Method Name New Method Name
append_at_cursor insert_text_at_caret
delete_char_at_cursor delete_char_at_caret
caret_blink cursor_set_blink_enabled set_caret_blink_enabled
" cursor_get_blink_enabled is_caret_blink_enabled
caret_blink_speed cursor_set_blink_speed set_caret_blink_speed
" cursor_get_blink_speed get_caret_blink_speed
caret_force_displayed cursor_set_force_displayed set_caret_force_displayed
" cursor_get_force_displayed is_caret_force_displayed
caret_position caret_column set_cursor_column set_caret_column
" get_cursor_position get_caret_column
expand_to_text_length set_expand_to_text_length set_expand_to_text_length_enabled
" get_expand_to_text_length is_expand_to_text_length_enabled
caret_mid_grapheme set_mid_grapheme_caret_enabled set_caret_mid_grapheme_enabled
" get_mid_grapheme_caret_enabled is_caret_mid_grapheme_enabled

scene/gui/line_edit.h Outdated Show resolved Hide resolved
doc/classes/LineEdit.xml Show resolved Hide resolved
scene/gui/line_edit.h Outdated Show resolved Hide resolved
scene/gui/line_edit.h Outdated Show resolved Hide resolved
@madmiraal madmiraal requested review from a team as code owners March 31, 2021 18:33
@madmiraal madmiraal changed the title Rename LineEdit caret_* properties getters and setters to match property Rename LineEdit getters and setters to match property names Mar 31, 2021
@madmiraal madmiraal requested a review from a team as a code owner April 5, 2021 15:53
@madmiraal
Copy link
Contributor Author

Rebased following merge of #46273.

@madmiraal
Copy link
Contributor Author

Rebased following merge of #47728.

@akien-mga akien-mga merged commit 8ba06e3 into godotengine:master Apr 19, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-lineedit-cursor branch April 19, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants