Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTML5] HTTP server now supports optional SSL #47974

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Apr 17, 2021

Generates a key/cert snakeoil pair or use a custom SSL cert/key.
This is of course false security, and potentially detrimental for it.

But, so long, those are the requirements browser vendors agreed on to use things like the Gamepad API, and more advanced topics like wasm threads.

You don't need this if you run on localhost (at least!), but you do need this (or a much safer nginx proxy) to try those things on your local network (e.g. when debugging a phone, networking, etc).

Depends on: #47386 (only check last commit for the diff).

web_ssl

@Faless Faless added this to the 4.0 milestone Apr 17, 2021
@Faless Faless changed the title [HTML5] HTTPServer now support optional SSL [HTML5] HTTP server now supports optional SSL Apr 17, 2021
@Faless
Copy link
Collaborator Author

Faless commented Apr 17, 2021

Updated 3.x backport here: https://github.com/Faless/godot/tree/js/3.x_http_server_backport

@Faless Faless marked this pull request as ready for review April 27, 2021 10:06
@Faless Faless requested a review from a team as a code owner April 27, 2021 10:06
Generates a key/cert snakeoil pair or use a custom SSL cert/key.
This is of course false security, and potentially detrimental for it.

But, so long, those are the requirements browser vendors agreed on to
use things like the Gamepad API, and more advanced topics like wasm
threads.

You don't need this if you run on localhost (at least!), but you do
need this (or a much safer nginx proxy) to try those things on your
local network (e.g. when debugging a phone, networking, etc).
@akien-mga akien-mga merged commit 6bcf98f into godotengine:master Apr 27, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants