Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable resource optimizations for release builds #50665

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jul 20, 2021

The behavior was enabled by default with AGP 4.2 but it breaks the legacy build system.

Fix #50623

@m4gr3d m4gr3d added this to the 4.0 milestone Jul 20, 2021
@m4gr3d m4gr3d requested a review from a team July 20, 2021 20:25
@m4gr3d m4gr3d changed the title Disable resource optimizations for release builds [WIP] Disable resource optimizations for release builds Jul 20, 2021
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Jul 20, 2021

The fix as is also affects the custom build, so I need to validate it has the proper behavior.

@m4gr3d m4gr3d force-pushed the disable_release_build_shrinking_master branch from 8242f3d to fa58777 Compare July 21, 2021 00:02
@m4gr3d m4gr3d changed the title [WIP] Disable resource optimizations for release builds Disable resource optimizations for release builds Jul 21, 2021
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Jul 21, 2021

PR's now ready for review!

@akien-mga akien-mga merged commit 60b4556 into godotengine:master Jul 21, 2021
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the disable_release_build_shrinking_master branch July 21, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release apk export missing icons and splashes
2 participants