Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint_transparent to use a transparent black placeholder texture (3.x) #51676

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 14, 2021

3.x version of #51672. Works in both GLES3 and GLES2.

Preview (GLES3)

hint_black's alpha channel

hint_black

hint_transparent's alpha channel

hint_transparent

@Calinou Calinou requested a review from a team as a code owner August 14, 2021 17:15
@Calinou Calinou added this to the 3.4 milestone Aug 14, 2021
@Calinou Calinou changed the title Add hint_transparent to use a transparent black placeholder texture Add hint_transparent to use a transparent black placeholder texture (3.x) Aug 15, 2021
@akien-mga akien-mga modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga modified the milestones: 3.5, 3.x Jul 3, 2022
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving (for 3.6) since the master PR was merged. Will need a rebase.

@Calinou Calinou force-pushed the shader-add-hint-transparent-texture-3.x branch from ed11c67 to ab9a95f Compare August 2, 2022 21:56
@Calinou
Copy link
Member Author

Calinou commented Aug 2, 2022

Rebased and tested again, it works as expected.

@akien-mga akien-mga merged commit 144f3ec into godotengine:3.x Aug 5, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 3.x, 3.5, 3.6 Aug 5, 2022
@Calinou Calinou deleted the shader-add-hint-transparent-texture-3.x branch August 6, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants