Add is_finite method for checking built-in types
#64268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It makes sense to rename |
Yeah. But I think renaming it is out of the scope of this PR. The naming is currently similar to C++ which provides both |
|
Thanks! |
aaronfranke
reviewed
Oct 11, 2022
Comment on lines
+694
to
+696
| bool Basis::is_finite() const { | ||
| return rows[0].is_finite() && rows[1].is_finite() && rows[2].is_finite(); | ||
| } |
There was a problem hiding this comment.
Considering you can validate a Basis by checking its determinant, I'm not sure this is helpful. The same likely applies to several other structures, there are other ways to validate them. But I guess it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves godotengine/godot-proposals#3790
This also makes fixing
NAN/INFrelated crashes easier.is_finiteis not added forColorbecause a finite color sounds weird.