Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GDScript preload fails in standalone build unless files are present in directory #65152

Merged
merged 1 commit into from Sep 15, 2022
Merged

Fix GDScript preload fails in standalone build unless files are present in directory #65152

merged 1 commit into from Sep 15, 2022

Conversation

s77rt
Copy link
Contributor

@s77rt s77rt commented Aug 31, 2022

Intro:
When exporting files into a pck format
files that are imported (those that have .import file) are replaced by whatever path is in the .import file + the .import file itself [ref].

Example:
adding audio.ogg will add instead audio.ogg.import and .godot/imported/audio.ogg-{hash}.oggvorbisstr

With the exception of files that are meant to be kept (see previous ref) + the icon and the splash files [ref]

Problem:
The problem is when checking for file existence, namely for preload where the gdscript analyser call FileAccess::exists(p_preload->resolved_path) it fails for every imported file (except the exceptions listed above), since audio.ogg does not exist (as per the example).

Solution:
Since for every imported file, the .import file is also added [ref], we can make a second check to check for that .import file instead.

Fixes #56343

@s77rt s77rt requested a review from a team as a code owner August 31, 2022 16:14
@Calinou Calinou added this to the 4.0 milestone Aug 31, 2022
@fire fire changed the title Fix 56343 Fix GDScript preload fails in standalone build unless files are present in directory Aug 31, 2022
reduz
reduz previously requested changes Sep 15, 2022
View reviewed changes
modules/gdscript/gdscript_analyzer.cpp Outdated
@@ -3189,7 +3189,7 @@ void GDScriptAnalyzer::reduce_preload(GDScriptParser::PreloadNode *p_preload) {
p_preload->resolved_path = parser->script_path.get_base_dir().path_join(p_preload->resolved_path);
}
p_preload->resolved_path = p_preload->resolved_path.simplify_path();
if (!FileAccess::exists(p_preload->resolved_path)) {
if (!FileAccess::exists(p_preload->resolved_path) && !FileAccess::exists(p_preload->resolved_path + ".import")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use ResourceLoader::exists instead of all this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and confirmed that this fixes the issue. I'll push an update directly to this PR to do that change and squash the commits / make the commit message clearer.

akien-mga
akien-mga approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@akien-mga akien-mga merged commit 2d3c148 into godotengine:master Sep 15, 2022
@akien-mga
Copy link
Member

akien-mga commented Sep 15, 2022 •
edited

Thanks! And congrats for your first merged Godot contribution 🎉

@s77rt s77rt deleted the fix-56343 branch September 15, 2022 20:35
Ongnissim added a commit to Ongnissim/godot that referenced this pull request Sep 16, 2022
@Ongnissim
Squashed commit of the following:
5718884 
commit c2babb6
Merge: 76b41bd 734b891
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:12:25 2022 +0200

    Merge pull request godotengine#65831 from bruvzg/vlk_edge_lag

    [macOS] Fix redraw lag at the edge of the resizing window.

commit 76b41bd
Merge: 78a9a3d badea35
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:12:18 2022 +0200

    Merge pull request godotengine#65830 from EricEzaM/fix-shortcut-crash

    Check TreeItem for nullptr before accessing.

commit 78a9a3d
Merge: 2d3c148 b6fdd08
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:12:12 2022 +0200

    Merge pull request godotengine#62903 from Rindbee/fix-property-link-not-work-in-MultiNodeEdit

    Set the changed field to empty (meaning all) if the link button is pressed

commit 2d3c148
Merge: 3ac332a 4dca997
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:11:57 2022 +0200

    Merge pull request godotengine#65152 from s77rt/fix-56343

    Fix GDScript preload fails in standalone build unless files are present in directory

commit 3ac332a
Merge: 7a90345 361ff55
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:11:50 2022 +0200

    Merge pull request godotengine#65819 from raulsntos/theme-docs

    Fix theme methods usage in docs

commit 7a90345
Merge: 80802d2 d762500
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:11:42 2022 +0200

    Merge pull request godotengine#65818 from raulsntos/dotnet/crypto-docs

    Fix invalid C# in crypto docs

commit 80802d2
Merge: 67c0514 cff95e5
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:11:36 2022 +0200

    Merge pull request godotengine#65196 from TokageItLab/fix-redraw-anim-tree

    Fix redraw timing in `AnimationBlendTreeEditor`

commit 67c0514
Merge: dbd757f 02ea1de
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:11:25 2022 +0200

    Merge pull request godotengine#65469 from BastiaanOlij/scene_data_reorg

    Extract shared scene data into a separate class

commit dbd757f
Merge: f2ba73f 0715250
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:11:19 2022 +0200

    Merge pull request godotengine#65760 from Mickeon/try-vformat-var-args

    Use variadic template in `vformat()` (allow more than 5 arguments)

commit f2ba73f
Merge: d39d462 9f1a57d
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 20:11:08 2022 +0200

    Merge pull request godotengine#63428 from fabriceci/fix-basis-get-axis-angle

    Test, refactor and fix a bug in Basis.get_axis_angle

commit d39d462
Merge: 4ba934b a5ffd25
Author: Ignacio Roldán Etcheverry <neikeq@users.noreply.github.com>
Date:   Thu Sep 15 18:37:12 2022 +0200

    Merge pull request godotengine#65823 from raulsntos/dotnet/signal-docs

    C#: Move signal documentation to the event

commit 734b891
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Tue Sep 13 15:33:51 2022 +0300

    [macOS] Fix redraw lag at the edge of the resizing window.

commit badea35
Author: Eric M <itsjusteza@gmail.com>
Date:   Thu Sep 15 23:50:52 2022 +1000

    Check TreeItem for nullptr before accessing.

commit 4dca997
Author: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
Date:   Wed Aug 31 16:52:37 2022 +0100

    Fix GDScript `preload` fails in standalone build unless files are present in directory

    Fixes godotengine#56343.

commit a5ffd25
Author: Raul Santos <raulsntos@gmail.com>
Date:   Thu Sep 15 13:24:41 2022 +0200

    C#: Move signal documentation to the event

    Move signal documentation from the delegate to the event and also
    deprecate the event if the signal is deprecated.

commit 361ff55
Author: Raul Santos <raulsntos@gmail.com>
Date:   Thu Sep 15 10:57:32 2022 +0200

    Fix theme methods usage in docs

    - Fix usages of `get_icon` that was renamed
    `get_theme_icon`.
    - Replace `new Control().get_font*` with
    `ThemeDB.fallback_font*`.

commit d762500
Author: Raul Santos <raulsntos@gmail.com>
Date:   Thu Sep 15 11:04:32 2022 +0200

    Fix invalid C# in crypto docs

commit 4ba934b
Merge: 20d6672 02bd072
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Thu Sep 15 09:48:13 2022 +0200

    Merge pull request godotengine#65507 from raulsntos/dotnet/nuget-fallback

    Fix NuGet fallback folder packages

commit 02bd072
Author: Raul Santos <raulsntos@gmail.com>
Date:   Wed Sep 7 19:21:13 2022 +0200

    Fix NuGet fallback folder packages

    - Creates a `Godot.Offline.Config` file to configurate NuGet with
    Godot's fallback folder. This is easier because now we can assume we can
    override the entire file since user config will likely be in the default
    `NuGet.Config` file or an additional `*.config` file.
    - Ensure the NuGet fallback folder is created at the same time it is
    added to the NuGet configuration so future builds don't fail.
    - Add `GodotSharp` and `GodotSharpEditor` packages to the fallback folder.
    - Add `.nupkg.metadata` file to packages in fallback folder.
    - Refer to `Godot.SourceGenerators` using the specific non-floating version
    since floating versions don't seem to work with fallbackPackageFolders.

commit 02ea1de
Author: Bastiaan Olij <mux213@gmail.com>
Date:   Wed Sep 7 21:23:01 2022 +1000

    Extract shared scene data into a separate class

commit 20d6672
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 01:47:27 2022 +0200

    Bump version to 4.0-beta \o/

    At long last!

    We're now pretty much feature complete (with a few exceptions which might
    still make their way to future betas) and ready to move on to the consolidation
    and bugfixing beta phase.

    The API is more or less settled for 4.0, though we still reserve the right to
    do changes if we see that it's really for the better - but from here on we'll
    do our best to ensure that early adopters of 4.0 beta have an easy upgrade path
    to future beta and eventually stable releases.

    A million of thanks to all contributors who worked so hard on shaping Godot 4.0
    over the past 3 years! Git counts nearly a thousand of you authoring close to
    11,000 unique commits (excluding merge commits). You're all breathtaking! <3

commit 51082d6
Merge: f11745d e7ce3f5
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 01:43:09 2022 +0200

    Merge pull request godotengine#65806 from akien-mga/pm-improve-conversion-dialog

    Clarify text in project conversion dialogs

commit f11745d
Merge: 3f0692f ef4f968
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Thu Sep 15 01:42:29 2022 +0200

    Merge pull request godotengine#65804 from clayjohn/octahedral-decode

commit e7ce3f5
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Thu Sep 15 00:45:59 2022 +0200

    Project Manager: Clarify text in project conversion dialogs

    Let the cancel button grab focus to prevent any accident.

    Make the full project conversion respect OS specific ok/cancel
    positions.

    Improve popup sizing and wrapping a bit.

commit 3f0692f
Merge: ecaa7b6 033abdc
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Thu Sep 15 00:52:42 2022 +0200

    Merge pull request godotengine#65801 from V-Sekai/skeleton-modification-docs

commit ef4f968
Author: clayjohn <claynjohn@gmail.com>
Date:   Wed Sep 14 15:48:03 2022 -0700

    Decode octahedral compression when retreiving meshes

commit 033abdc
Author: Lyuma <xn.lyuma@gmail.com>
Date:   Tue Sep 13 19:59:17 2022 -0700

    2D and 3D Skeleton modification docs, and small fixes.

    Mark SkeletonModificationStack3D and related as deprecated.
    Mark local bone override and axis functions deprecated in Skeleton3D api.
    Fix array property glitch in SkeletonModificationStack2D
    Mark SkeletonModificationStack2D and related APIs as experimental. Mark SkeletonIK3D as deprecated.

commit ecaa7b6
Merge: 6fd3f6a e844b95
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Thu Sep 15 00:03:40 2022 +0200

    Merge pull request godotengine#65322 from ceLoFaN/fix-dof-artifact-at-high-blur

commit 0715250
Author: Micky <micheledevita2@gmail.com>
Date:   Tue Sep 13 22:27:10 2022 +0200

    Use variadic template in `vformat()`

    Allows `vformat()` to take more than 5 arguments. as well as being a general optimisation that avoids redundant empty Variant checks.

commit 6fd3f6a
Merge: 0ef17b3 219a582
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 23:13:35 2022 +0200

    Merge pull request godotengine#65048 from rburing/solve_static_world_boundary_motion_2d

commit 0ef17b3
Merge: b094e4f 9239c61
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 22:38:08 2022 +0200

    Merge pull request godotengine#65796 from clayjohn/GLES3-canvas-shader

commit b094e4f
Merge: fff0970 82d2a97
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 22:07:15 2022 +0200

    Merge pull request godotengine#64092 from nathanfranke/shader-uniform

commit 9239c61
Author: clayjohn <claynjohn@gmail.com>
Date:   Wed Sep 14 12:41:08 2022 -0700

    Fix canvasitem shader builtins when using GLES3
    Remove prefix canvas_data. as it isn't used in the internal canvasitem shader

commit fff0970
Merge: 6c352c1 bb657c0
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 21:17:30 2022 +0200

    Merge pull request godotengine#65628 from JohanAR/particle_billboard_normal

    Calculate MODELVIEW_NORMAL_MATRIX for billboard materials

commit 6c352c1
Merge: 0a0843a bbaf53e
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 21:15:06 2022 +0200

    Merge pull request godotengine#65491 from MJacred/docs/multimesh

    Document MultiMesh members

commit 0a0843a
Merge: 5d6a719 ddfa214
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 19:07:33 2022 +0200

    Merge pull request godotengine#65654 from JohanAR/emit_subparticle_from_start

    Allow emit_subparticle from start function

commit 5d6a719
Merge: 957aa79 f4f556d
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 19:06:39 2022 +0200

    Merge pull request godotengine#65788 from bruvzg/macos_fix_dotnet_detection

    [macOS, .NET] Fix dotnet binary detection.

commit 957aa79
Merge: f709596 72d8997
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 19:06:19 2022 +0200

    Merge pull request godotengine#65789 from clayjohn/sky-update-bug

    Clear last frame directional light buffer when number of lights changes.

commit f709596
Merge: a9b04b9 74cdee4
Author: Clay John <claynjohn@gmail.com>
Date:   Wed Sep 14 09:06:27 2022 -0700

    Merge pull request godotengine#65418 from JFonS/taa_multimesh

    Add motion vectors support for MultiMeshInstance

commit a9b04b9
Merge: 89840b7 299585f
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Wed Sep 14 17:43:54 2022 +0200

    Merge pull request godotengine#65783 from Geometror/graphedit-configuration-warning

    Add configuration warning to GraphEdit regarding future refactoring

commit 299585f
Author: Hendrik Brucker <hendrik.brucker@mail.de>
Date:   Wed Sep 14 18:09:21 2022 +0200

    Add configuration warning to GraphEdit regarding future refactoring

commit 89840b7
Merge: 56fb2d1 4d898f9
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Wed Sep 14 17:43:49 2022 +0200

    Merge pull request godotengine#65430 from SaracenOne/read_only_array

    Add read-only mode to inspector array and dictionary viewer.

commit 56fb2d1
Merge: bbed0b4 534ff93
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Wed Sep 14 17:43:05 2022 +0200

    Merge pull request godotengine#65775 from smix8/navigation_baking_disabled_shapes_4.x

    Exclude disabled StaticBody CollisionShapes from Navigationmesh baking

commit bbed0b4
Merge: 5ff8e4e e94ac75
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Wed Sep 14 17:42:58 2022 +0200

    Merge pull request godotengine#65774 from bruvzg/no_mono_hinting

    Do not use horizontal hinting for the editor monospace font.

commit 5ff8e4e
Merge: bf271ea 77a4567
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Wed Sep 14 17:42:53 2022 +0200

    Merge pull request godotengine#65133 from bruvzg/win_cursor

    [Windows] Simplify cursor handling and add support for fully transparent cursors.

commit f4f556d
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Wed Sep 14 18:13:06 2022 +0300

    [macOS, .NET] Fix dotnet binary detection.

commit 72d8997
Author: clayjohn <claynjohn@gmail.com>
Date:   Wed Sep 14 08:30:35 2022 -0700

    Clear last frame directional light buffer when number of lights changes.
    This ensures that the buffers don't go out of sync.

commit bf271ea
Merge: 85cd696 d1d9b72
Author: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
Date:   Wed Sep 14 15:54:39 2022 +0200

    Merge pull request godotengine#64228 from nathanfranke/mp-load

    Multiplayer: Do not load PackedScene from spawner until instantiating

commit 85cd696
Merge: 50a6905 1e99c13
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 14:44:03 2022 +0200

    Merge pull request godotengine#65494 from V-Sekai/fix_inspect_command_context

commit 50a6905
Merge: d9e974c 15e2ddb
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 14:42:18 2022 +0200

    Merge pull request godotengine#65421 from V-Sekai/spriteframes_read_only

commit cff95e5
Author: Silc Renew <tokage.it.lab@gmail.com>
Date:   Thu Sep 1 23:00:55 2022 +0900

    Fix redraw timing in AnimationBlendTreeEditor

commit 9f1a57d
Author: fabriceci <fabricecipolla@gmail.com>
Date:   Mon Jul 25 11:01:26 2022 +0200

    Test, refactor and fix a bug in Basis.get_axis_angle

commit 534ff93
Author: smix8 <52464204+smix8@users.noreply.github.com>
Date:   Wed Sep 14 10:41:33 2022 +0200

    Exclude disabled CollisionShapes from Navigationmesh baking

    Excludes disabled CollisionShapes from the geometry parsing for the NavigationMesh baking.

commit e94ac75
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Wed Sep 14 11:05:09 2022 +0300

    Do not use horizontal hinting for the editor monospace font.

commit d9e974c
Merge: 240fb86 13f5c62
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 09:57:02 2022 +0200

    Merge pull request godotengine#65493 from V-Sekai/lod_scaling

    Fixes LOD scaling issues on skinned meshes.

commit 240fb86
Merge: dbd6fa7 d46bc8f
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 09:34:54 2022 +0200

    Merge pull request godotengine#61901 from bruvzg/macos_live_resize_fix_4

commit d46bc8f
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Fri Jun 10 14:02:51 2022 +0300

    [macOS, 4.0] Fix unresponsive redraw during live resizing.

commit dbd6fa7
Merge: e5963cf 2ece5b4
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 07:59:59 2022 +0200

    Merge pull request godotengine#65737 from bruvzg/font_do_not_emit_from_dtr

    [Font] Remove unnecessary cleanup and `changed` signal emission from the destructor.

commit e5963cf
Merge: b1139ff 2aa226f
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 07:59:21 2022 +0200

    Merge pull request godotengine#65735 from bruvzg/rtl_fixes

    RTL Improvements

commit b1139ff
Merge: b1e54ef 9d5e48f
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 07:32:47 2022 +0200

    Merge pull request godotengine#65769 from m4gr3d/update_android_editor_menus_main

    Disable menus and functionality that are not relevant on the Android Editor port

commit b1e54ef
Merge: 2d9583f 70d3935
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 07:31:54 2022 +0200

    Merge pull request godotengine#65766 from BastiaanOlij/openxr_1_0_25

    Update OpenXR to 1.0.25

commit 9d5e48f
Author: Fredia Huya-Kouadio <fhuya@fb.com>
Date:   Tue Sep 13 20:48:33 2022 -0700

    Disable menus and functionality that are not relevant on the Android Editor port

commit 13f5c62
Author: SaracenOne <SaracenOne@gmail.com>
Date:   Wed Sep 7 20:13:10 2022 +0100

    Fix LOD-generation on skinned meshes.

commit 70d3935
Author: Bastiaan Olij <mux213@gmail.com>
Date:   Wed Sep 14 11:20:54 2022 +1000

    Update OpenXR to 1.0.25

commit d1d9b72
Author: Nathan Franke <me@nathan.sh>
Date:   Wed Aug 10 10:40:19 2022 -0500

    do not load PackedScene from spawner until instantiating

commit 2d9583f
Merge: d33db36 026e081
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 00:04:56 2022 +0200

    Merge pull request godotengine#65490 from halgriffiths/profiler-fix

    Fix broken profiler in 4.0

commit d33db36
Merge: 2e6ba5f 21f7bd0
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Wed Sep 14 00:00:03 2022 +0200

    Merge pull request godotengine#65648 from TedSpikes/check-for-ios-simulator

    Check for ios_simulator when building for iOS and x86_64

commit 2e6ba5f
Merge: eb4ac38 9f70848
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 23:56:53 2022 +0200

    Merge pull request godotengine#65746 from clayjohn/GLES3-mem-leak

    Fix leaking of Mesh version and lod memory when freeing mesh in GLES3

commit eb4ac38
Merge: 315eade 8fa76a5
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 23:56:25 2022 +0200

    Merge pull request godotengine#65756 from clayjohn/sky-shader-debanding

    Move debanding into internal sky shader

commit 315eade
Merge: f6b36f5 ae2d07d
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 21:33:26 2022 +0200

    Merge pull request godotengine#65754 from KoBeWi/nothing_to_do_here

    Don't print error on empty actions

commit 8fa76a5
Author: clayjohn <claynjohn@gmail.com>
Date:   Tue Sep 13 10:39:04 2022 -0700

    Move debanding into internal sky shader code so that it is applied after everything else.

    This ensures that the debanding does not scale with exposure or any other effect.

commit ae2d07d
Author: kobewi <kobewi4e@gmail.com>
Date:   Tue Sep 13 19:35:25 2022 +0200

    Don't print error on empty actions

commit 9f70848
Author: clayjohn <claynjohn@gmail.com>
Date:   Tue Sep 13 08:19:14 2022 -0700

    Fix leaking of Mesh version and lod memory when freeing mesh in GLES3

commit f6b36f5
Merge: 22a09fe dbff58e
Author: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
Date:   Tue Sep 13 17:10:38 2022 +0200

    Merge pull request godotengine#65659 from Faless/rtc/4.x_expose_more

    [WebRTC] Expose more of the WebRTC API.

commit dbff58e
Author: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
Date:   Thu Sep 8 04:39:32 2022 +0200

    [WebRTC] Expose more of the WebRTC API.

    Add get_gathering_state() returning the iceGatheringState of the
    connection.

    Add get_signaling_state() returning the signalingState of the
    connection.

    Improve JS library.

commit 21f7bd0
Author: Ted Spikes <ted@tedspikes.com>
Date:   Sun Sep 11 09:21:41 2022 +0000

    Check for ios_simulator when building for x86_64

commit 026e081
Author: halgriffiths <henrygriffiths@improbable.io>
Date:   Tue Sep 6 16:15:00 2022 +0100

    Fix profiler being disabled at wrong times
    Co-authored by: Will Whitty <tavurth@gmail.com>

commit 22a09fe
Merge: ff824b6 3d08678
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Tue Sep 13 11:01:33 2022 +0200

    Merge pull request godotengine#65579 from ZuBsPaCe/fix-viewport-sibling-order

    Sibling SubViewports must be rendered from top to bottom

commit ff824b6
Merge: 3a82a13 0aecfc9
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Tue Sep 13 11:01:12 2022 +0200

    Merge pull request godotengine#65509 from gotnospirit/master-os-get_datetime

    get_datetime_* functions can return wrong values

commit 3a82a13
Merge: abdaa6d ed4fe1e
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Tue Sep 13 10:58:55 2022 +0200

    Merge pull request godotengine#65591 from MewPurPur/area-overlapping-function

    Implement `Area[2D/3D].has_overlapping_[bodies/areas]`

commit abdaa6d
Merge: ecefae2 aafe72f
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Tue Sep 13 10:58:29 2022 +0200

    Merge pull request godotengine#65621 from KoBeWi/eternal_pattern

    Fix broken patterns on TileMap layer change

commit ecefae2
Merge: 5c1ef35 7fc075d
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Tue Sep 13 10:58:25 2022 +0200

    Merge pull request godotengine#65624 from KoBeWi/help_I'm_stuck

    Prevent infinite loops in editor help search

commit 5c1ef35
Merge: 2ac8bcd 6ce0d3a
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Tue Sep 13 10:58:19 2022 +0200

    Merge pull request godotengine#65262 from bruvzg/win10_dm

    Disable dark mode title bar on Windows 10.

commit 2ac8bcd
Merge: be0b77f c2553f5
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Tue Sep 13 10:58:09 2022 +0200

    Merge pull request godotengine#65632 from YeldhamDev/thin_editors

    Shrink shader editor's oversized borders

commit be0b77f
Merge: b2875d1 0fd29f7
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:46:49 2022 +0200

    Merge pull request godotengine#65642 from voylin/fix_spaces_in_path_for_doc/makefile

commit b2875d1
Merge: b853110 e5814c3
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:45:50 2022 +0200

    Merge pull request godotengine#65643 from voylin/fix_recurring_check_in_gdscript_cache.cpp

commit b853110
Merge: fc61fa3 e4a8646
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:44:41 2022 +0200

    Merge pull request godotengine#65653 from Chaosus/shader_completion_fix

commit fc61fa3
Merge: ed38107 177f2a8
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:43:16 2022 +0200

    Merge pull request godotengine#65611 from Sarfraz-droid/Issue65602

commit ed38107
Merge: 967938d f9bee90
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:42:49 2022 +0200

    Merge pull request godotengine#65651 from dzil123/animation_tree_node_rename

commit 967938d
Merge: 78042ce 899b73e
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:40:53 2022 +0200

    Merge pull request godotengine#65637 from Jummit/assert-example

commit 2aa226f
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Tue Sep 13 09:25:38 2022 +0300

    RTL Improvements

    Do not apply negative line separation to the last line.
    Ensure all methods immediately update cache in a single thread mode.
    Fix bbcode_enabled change not being applied until text is changed.
    Fix crash if line height is zero or less.

commit 78042ce
Merge: ad09e67 305d407
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:39:15 2022 +0200

    Merge pull request godotengine#64927 from KoBeWi/three2four

commit ad09e67
Merge: f9b4af4 1efafa9
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:38:21 2022 +0200

    Merge pull request godotengine#65682 from m4gr3d/update_editor_versioning_main

commit f9b4af4
Merge: 2092858 fc227ea
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:35:27 2022 +0200

    Merge pull request godotengine#65708 from akien-mga/vcs-plugin-ssh-key-HOME

commit 2092858
Merge: c2b1b3a 598b5b1
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:32:47 2022 +0200

    Merge pull request godotengine#65679 from Calinou/3d-editor-improve-preview-sun-sky-usability

commit c2b1b3a
Merge: 0f3f850 d5c703b
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:31:47 2022 +0200

    Merge pull request godotengine#65720 from KoBeWi/animated_diff

commit 0f3f850
Merge: c4fc473 873366c
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 10:25:11 2022 +0200

    Merge pull request godotengine#65738 from BastiaanOlij/fix_ssao_ssil_memory_leak

commit c4fc473
Merge: f8ec046 d2ba60b
Author: Yuri Rubinsky <chaosus89@gmail.com>
Date:   Tue Sep 13 10:51:41 2022 +0300

    Merge pull request godotengine#65736 from Chaosus/vs_fix

commit 873366c
Author: Bastiaan Olij <mux213@gmail.com>
Date:   Tue Sep 13 17:49:32 2022 +1000

    Fix uniform buffer being created every frame is SSAO and SSIL half_size is different

commit 2ece5b4
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Tue Sep 13 10:28:12 2022 +0300

    [Font] Remove unnecessary cleanup and `changed` signal emission from the destructor.

commit d2ba60b
Author: Yuri Rubinsky <chaosus89@gmail.com>
Date:   Tue Sep 13 10:06:34 2022 +0300

    Fix category of view_index inputs in the visual shader editor

commit f8ec046
Merge: 0b716fd 1513d76
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 08:31:59 2022 +0200

    Merge pull request godotengine#65704 from akien-mga/web-editor-fix-some-errors

    Fix some errors affecting the Web editor

commit 0b716fd
Merge: 6a8b2a4 96b7cb6
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 08:23:16 2022 +0200

    Merge pull request godotengine#65727 from clayjohn/GLES3-multiwindow

    Fix multiwindow support in GLES3 for X11, Windows, and MacOS.

commit 6a8b2a4
Merge: 16228ba 020b8e6
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Tue Sep 13 08:19:44 2022 +0200

    Merge pull request godotengine#65728 from nathanfranke/longest-item

    Change project manager language dropdown to not fit to longest item.

commit 020b8e6
Author: Nathan Franke <me@nathan.sh>
Date:   Mon Sep 12 19:59:16 2022 -0500

    project manager language OptionButton fit to longest item

commit 96b7cb6
Author: clayjohn <claynjohn@gmail.com>
Date:   Mon Sep 12 14:57:11 2022 -0700

    Fix multiwindow support in GLES3 for X11, Windows, and MacOS.

    Instead of updating all viewports, then blitting all viewports
    to the backbuffer, then swapping all buffers, we run through
    all viewports and render, blit, and swap backbuffer before
    going to the next viewport.

commit 16228ba
Merge: 79b21e9 7f30e81
Author: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
Date:   Tue Sep 13 00:19:38 2022 +0300

    Merge pull request godotengine#65670 from Jayman2000/fix-rst-doc-literals

    Fix invalid literals in generated rst docs

commit d5c703b
Author: kobewi <kobewi4e@gmail.com>
Date:   Mon Sep 12 22:59:35 2022 +0200

    Don't store frame of playing AnimatedSprite

commit 7f30e81
Author: Jason Yundt <jason@jasonyundt.email>
Date:   Mon Sep 12 15:51:39 2022 -0400

    Fix invalid literals in generated rst docs

    Before this change, API docs that look like this:

    	…adding [param character]s to the right of the string.

    would turn into rst files that look like this:

    	…adding ``character``s to the right of the string.

    That reStructuredText is invalid and causes warnings when the docs repo
    is built.

commit 79b21e9
Merge: 677ccb9 97be1fb
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 20:42:27 2022 +0200

    Merge pull request godotengine#65544 from clayjohn/lambert-wrap

    Apply energy conservation to LAMBERT_WRAP diffuse mode by dividing by PI

commit 677ccb9
Merge: 44c55ad 05f351b
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 20:40:52 2022 +0200

    Merge pull request godotengine#65709 from clayjohn/GLES3-render-target-type

    Use proper color type for transparent render targets in GLES3

commit 1efafa9
Author: Fredia Huya-Kouadio <fhuyakou@gmail.com>
Date:   Mon Sep 12 09:47:34 2022 -0700

    Exclude small screens from the set of supported devices.

commit 67b38d0
Author: Fredia Huya-Kouadio <fhuyakou@gmail.com>
Date:   Sun Sep 11 21:33:17 2022 -0700

    Update the versioning logic for the Godot Android Editor

    This is necessary to separate subsequent uploads to the Google Play store as each upload needs to increment the version code.

commit 305d407
Author: kobewi <kobewi4e@gmail.com>
Date:   Fri Aug 26 15:22:30 2022 +0200

    Add option to convert project from Project Manager

commit 97be1fb
Author: clayjohn <claynjohn@gmail.com>
Date:   Thu Sep 8 13:55:49 2022 -0700

    Apply energy conservation to LAMBERT_WRAP and TOON diffuse modes by dividing by PI

commit 05f351b
Author: clayjohn <claynjohn@gmail.com>
Date:   Mon Sep 12 08:19:03 2022 -0700

    Use proper color type for transparent render targets in GLES3

commit fc227ea
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Mon Sep 12 16:58:40 2022 +0200

    VCS plugin: SSH key dialog defaults to HOME

    Fixes godotengine#65691.

commit 44c55ad
Merge: dbab737 038cb67
Author: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
Date:   Mon Sep 12 17:54:44 2022 +0300

    Merge pull request godotengine#65658 from KoBeWi/Two_Tweens_are_tweening_the_same_object._Who-will-win

    Add more clarifications about Tween processing

commit 1513d76
Author: Rémi Verschelde <rverschelde@gmail.com>
Date:   Mon Sep 12 16:29:40 2022 +0200

    Fix some errors affecting the Web editor

    - Don't warn about minimized/maximized modes not being available.
    - Blender and FBX export both depend on running thirdparty applications,
      which can't be done (easily at least) for Web and Android editors.
    - Editor theme complained about not being able to retrieve texture data
      for an icon. It was only used once so instead of flipping at runtime,
      let's just add a flipped icon.

    Part of godotengine#65702.

commit dbab737
Merge: f211869 cdc57a7
Author: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
Date:   Mon Sep 12 15:34:35 2022 +0200

    Merge pull request godotengine#65697 from Faless/mp/4.x_spawner_crash

    [Multiplayer] Fix crash in spawner get_spawnable_scene.

commit 74cdee4
Author: jfons <joan.fonssanchez@gmail.com>
Date:   Fri Aug 5 09:19:52 2022 +0200

    Add motion vectors support for MultiMeshInstance

    Transparently handle changes in multimesh transforms so they get reflected in the motion vectors buffer.

commit cdc57a7
Author: Fabio Alessandrelli <fabio.alessandrelli@gmail.com>
Date:   Mon Sep 12 14:46:35 2022 +0200

    [Multiplayer] Fix crash in spawner get_spawnable_scene.

commit f211869
Merge: fefa3e9 65f0113
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 14:23:04 2022 +0200

    Merge pull request godotengine#65594 from clayjohn/SSR-dialectric

commit fefa3e9
Merge: 43a3fc7 533e366
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 13:26:20 2022 +0200

    Merge pull request godotengine#65688 from Chaosus/fix_astargrid_heuristic

commit 43a3fc7
Merge: 97830e7 cc4bda8
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 12:19:22 2022 +0200

    Merge pull request godotengine#64982 from V-Sekai/exp_dep_flags

commit 533e366
Author: Yuri Rubinsky <chaosus89@gmail.com>
Date:   Mon Sep 12 11:34:16 2022 +0300

    Fix incorrect heuristic order in `AStarGrid2D`

commit 97830e7
Merge: 7535c6c b648ee4
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 12:15:58 2022 +0200

    Merge pull request godotengine#64155 from Mickeon/sprite-3d-backwards-speed-scale

commit 7535c6c
Merge: baded9f 213bd41
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 09:11:06 2022 +0200

    Merge pull request godotengine#65687 from Chaosus/gds_fix_script_time

    Fix last_modified_time on scripts

commit 213bd41
Author: Yuri Rubinsky <chaosus89@gmail.com>
Date:   Mon Sep 12 09:21:00 2022 +0300

    Fix last_modified_time on scripts

commit baded9f
Merge: 200b9cd b519d76
Author: Rémi Verschelde <remi@verschelde.fr>
Date:   Mon Sep 12 07:22:52 2022 +0200

    Merge pull request godotengine#65676 from BastiaanOlij/fix_msaa_taa_issue

    Fixed MSAA initialisation in clustered forward renderer

commit 598b5b1
Author: Hugo Locurcio <hugo.locurcio@hugo.pro>
Date:   Mon Sep 12 03:57:13 2022 +0200

    Improve 3D editor preview sun and sky usability

    - Use grayscale icons to look better when pressed (with accent color
      modulation).
    - Invert state to be more logical (pressed = preview is enabled, not disabled).

commit b519d76
Author: Bastiaan Olij <mux213@gmail.com>
Date:   Mon Sep 12 11:07:51 2022 +1000

    Fixed MSAA initialisation in clustered forward renderer

commit 038cb67
Author: kobewi <kobewi4e@gmail.com>
Date:   Sun Sep 11 17:39:35 2022 +0200

    Add more clarifications about Tween processing

commit e4a8646
Author: Yuri Rubinsky <chaosus89@gmail.com>
Date:   Sun Sep 11 14:49:19 2022 +0300

    Prevent duplicated hints in shader uniform completion

commit ddfa214
Author: Johan Aires Rastén <johan@oljud.se>
Date:   Sun Sep 11 14:00:36 2022 +0200

    Allow emit_subparticle from start function

    emit_subparticle was previously only allowed from the process function
    in a particle shader, which seemed like an unnecessary limitation.

commit 0fd29f7
Author: Voylin <0voylin0@gmail.com>
Date:   Sun Sep 11 16:48:31 2022 +0900

    Fixes doc/Makefile fails if path contains spaces

commit f9bee90
Author: dzil123 <5725958+dzil123@users.noreply.github.com>
Date:   Sun Sep 11 02:33:59 2022 -0700

    Ignore node rename if already exited blend tree

commit e5814c3
Author: Voylin <0voylin0@gmail.com>
Date:   Sun Sep 11 16:56:49 2022 +0900

    Fix for recurring check in gdscript_cach.cpp

commit 899b73e
Author: Jummit <jummit@web.de>
Date:   Sun Sep 11 07:55:03 2022 +0200

    Remove outdated assert example

commit cc4bda8
Author: SaracenOne <SaracenOne@gmail.com>
Date:   Sun Aug 28 07:17:25 2022 +0100

    Add ability to flag classes as experimental or deprecated.

commit c2553f5
Author: Michael Alexsander <michaelalexsander@protonmail.com>
Date:   Sat Sep 10 17:35:50 2022 -0300

    Shrink shader editor's oversized borders

commit bb657c0
Author: Johan Aires Rastén <johan@oljud.se>
Date:   Sat Sep 10 21:08:29 2022 +0200

    Calculate MODELVIEW_NORMAL_MATRIX for billboard materials

    Solves godotengine#65627

commit 177f2a8
Author: Sarfraz <alamsarfraz422@gmail.com>
Date:   Sat Sep 10 16:47:55 2022 +0530

    Fix gltf 8 bone weights condition to check for the second joint array
    size.

commit 7fc075d
Author: kobewi <kobewi4e@gmail.com>
Date:   Sat Sep 10 19:34:26 2022 +0200

    Prevent infinite loops in editor help search

commit aafe72f
Author: kobewi <kobewi4e@gmail.com>
Date:   Sat Sep 10 16:45:25 2022 +0200

    Fix broken patterns on TileMap layer change

commit ed4fe1e
Author: VolTer <mew.pur.pur@abv.bg>
Date:   Fri Sep 9 23:26:14 2022 +0200

    Implement Area.has_overlapping_*

commit 0aecfc9
Author: James <gotnospirit@gmail.com>
Date:   Thu Sep 8 13:36:10 2022 +0800

    Fixes godotengine#65377: get_datetime_* functions can return wrong values

commit 65f0113
Author: clayjohn <claynjohn@gmail.com>
Date:   Fri Sep 9 15:52:07 2022 -0700

    Properly scale SSR reflection based on metallic value for dielectric materials

commit b648ee4
Author: Micky <micheledevita2@gmail.com>
Date:   Tue Aug 9 12:57:18 2022 +0200

    Harmonise AnimatedSprite3D and its 2D counterpart

    Add the following properties to AnimatedSprite3D:
    - `backwards` parameter in `play()`;
    - `speed_scale`.

    Both classes' internals are more similar, down to the line spacings. They've also been updated to be clearer and less inconsistent (e.g. `!frames.is_valid()` -> `frames.is_null()`, use SceneStringNames instead of CoreStringNames, rename the internal _queue_update to _queue_redraw)

commit 3d08678
Author: ZuBsPaCe <kurt.rudin@gmx.net>
Date:   Fri Sep 9 11:28:01 2022 +0200

    Sibling SubViewports must be rendered from top to bottom

    Sibling SubViewports must be rendered in the same order as in the Scene Tree, from top to bottom. _sort_active_viewports() reversed their order.
    Fixes godotengine#65545

commit bbaf53e
Author: MJacred <loesch.benny92@gmx.de>
Date:   Thu Sep 8 14:28:38 2022 +0200

    Document MultiMesh members and improve/extend existing descriptions

commit 1e99c13
Author: SaracenOne <SaracenOne@gmail.com>
Date:   Wed Sep 7 10:14:06 2022 +0100

    In inspector, show 'edit' button instead of 'inspect' when resource is part of an editable scene.

commit 4d898f9
Author: SaracenOne <SaracenOne@gmail.com>
Date:   Tue Sep 6 16:59:36 2022 +0100

    Add read-only mode to inspector array and dictionary viewer.

commit 15e2ddb
Author: SaracenOne <SaracenOne@gmail.com>
Date:   Tue Sep 6 14:47:13 2022 +0100

    Add read only mode to SpriteFrames editor.

commit e844b95
Author: ceLoFaN <ncefalo@pm.me>
Date:   Sun Sep 4 13:23:49 2022 +0300

    Fix DoF artifacting at high blur amounts

commit 6ce0d3a
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Fri Sep 2 21:44:58 2022 +0300

    Disable dark mode title bar on Windows 10.

commit 82d2a97
Author: Nathan Franke <me@nathan.sh>
Date:   Mon Aug 8 01:57:08 2022 -0500

    prefix shader parameters with "shader_parameter/"

commit 77a4567
Author: bruvzg <7645683+bruvzg@users.noreply.github.com>
Date:   Tue Aug 30 18:50:56 2022 +0300

    [Windows] Simplify cursor handling and add support for fully transparent cursors.

commit 219a582
Author: Ricardo Buring <ricardo.buring@gmail.com>
Date:   Mon Aug 29 17:34:06 2022 +0200

    Fix collision solving between world boundary and shapes in motion (2D)

commit b6fdd08
Author: Rindbee <idleman@yeah.net>
Date:   Mon Jul 11 10:13:34 2022 +0800

    Fix property link not working in MultiNodeEdit

    This is due to the `p_field` in the `EditorProperty::emit_changed`.
    `p_field` only works for `MultiNodeEdit`, not for other objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@reduz reduz reduz left review comments

Assignees
No one assigned
Labels
bug topic:export topic:gdscript
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Godot 4.0 GDScript preload fails in standalone build unless files are present in directory
4 participants
@s77rt @akien-mga @reduz @Calinou