Fix wrong AnimationStateMachine process for end of fading
#70572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
changed the title
TokageItLab
changed the title
AnimationStateMachine condition for end of fading
TokageItLab
force-pushed
the
fix-statemachine-fade
branch
from
df8f698
to
8adc357
Compare
TokageItLab
force-pushed
the
fix-statemachine-fade
branch
3 times, most recently
from
1ee36dc
to
0944522
Compare
TokageItLab
changed the title
AnimationStateMachine condition for end of fadingAnimationStateMachine process for end of fading
TokageItLab
force-pushed
the
fix-statemachine-fade
branch
from
0944522
to
74e0903
Compare
|
I just tested it with our projects, and it does fix the player characters' state machines. Thanks! |
|
I've tested this fix, and it seems to solve my issues mentioned in the issue 70536. |
akien-mga
approved these changes
Jan 3, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70536
Follow up #70278
The proper implementation is not to change the blend value threshold of the fade, but to change the order of the fade termination process.