Allow DEBUG_ENABLED
to be toggled independently of TOOLS_ENABLED
#73668
+85
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes debugging of unusual release-only issues such as godotengine/godot-cpp#842 easier from an editor build without needing to make a separate template build to reproduce them.
This is mostly useful for
target=editor
since there is at present no way to make a "release editor".For example, these will build debug builds without the
DEBUG_ENABLED
macro (perhaps to allow debugging of release-specific crashes)or build a release build with optimizations, but with
DEBUG_ENABLED
turned on.debug_features
defaults toauto
which isyes
fortarget=template_release
andno
fortarget=editor
ortarget=template_debug
There could be usecases for building a debuggable template, but it's unclear what the difference is between my proposed
target=template_debug debug_features=no
andtarget=template_release optimization=debug debug_symbols=yes
I'd be open to adding
target=editor_release
instead if it makes more sense.Regarding the changes in the PR, they are to make checks consistent across the codebase.
As one example, ClassDB metadata and argument info are enabled when
DEBUG_METHODS_ENABLED
(which means the same thing asDEBUG_ENABLED
, I think?), so it makes sense to permit--dump-gdextension-api
whenDEBUG_ENABLED
.