Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Detect host OS and use macOS keys on Mac hosts. #75451

Merged
merged 1 commit into from
Apr 11, 2023
Merged

[Web] Detect host OS and use macOS keys on Mac hosts. #75451

merged 1 commit into from
Apr 11, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 29, 2023

  • Adds web_android, web_ios, web_linuxbsd, web_macos, and web_windows OS feature tags based on the host platform.
  • Uses runtime checks/overrides for the default keys based on macos and web_macos tags instead of ifdefs.

Fixes #68653

@bruvzg bruvzg added this to the 4.x milestone Mar 29, 2023
@bruvzg bruvzg marked this pull request as ready for review March 29, 2023 12:41
@bruvzg bruvzg requested review from a team as code owners March 29, 2023 12:41
@akien-mga akien-mga modified the milestones: 4.x, 4.1 Apr 5, 2023
@akien-mga akien-mga requested a review from Faless April 5, 2023 11:46
Faless
Faless requested changes Apr 10, 2023
View reviewed changes
platform/web/os_web.cpp Outdated Show resolved Hide resolved
Faless
Faless approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚀 🍎

@akien-mga akien-mga merged commit 5722d6e into godotengine:master Apr 11, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Jun 16, 2023
Merged
@akien-mga akien-mga changed the title [Web] Detect host OS and use macOS keys on mac hosts. [Web] Detect host OS and use macOS keys on Mac hosts. Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos platform:web topic:input topic:porting
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

TextEdit uses wrong copy/paste shortcuts on Mac in HTML5 build
3 participants
@bruvzg @akien-mga @Faless