Add a --audio-output-latency command-line argument
#78013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
reviewed
Jun 9, 2023
RandomShaper
approved these changes
Jun 9, 2023
Calinou
force-pushed
the
cli-add-audio-output-latency-argument
branch
2 times, most recently
from
3ca00cb
to
e48c448
Compare
akien-mga
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Seems fine.
I'm a bit unsure about how many command line options we want to expose to tweak all possible settings a project may or may not intentionally expose... but @ellenhp approved this proposal so I think it's good to go.
|
Needs rebase. |
Calinou
force-pushed
the
cli-add-audio-output-latency-argument
branch
from
e48c448
to
43fdcb4
Compare
This allows optimizing the audio output latency on higher-end CPUs, especially in projects that do not expose a way to override this setting.
Calinou
force-pushed
the
cli-add-audio-output-latency-argument
branch
from
43fdcb4
to
6f1152b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--max-fpscommand-line argument to set a FPS limit #78012 (can be merged independently).This allows optimizing the audio output latency on higher-end CPUs, especially in projects that do not expose a way to override this setting.
It would be good to figure out a way to change this value at run-time, so that it can be exposed in game configuration menus as well. That said, it's better than nothing to be able to adjust the output latency somehow as a user – especially for small game projects which may not bother exposing a setting for it 🙂
--audio-output-latencycommand line argument to override the audio mix latency on any project godot-proposals#5450.