Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added brew option to the list of paths for the dotnet finder #78994

Closed
wants to merge 1 commit into from

Conversation

shinspiegel
Copy link

@shinspiegel shinspiegel commented Jul 3, 2023

This is an attempt to solve the issue on this: #75668

This is an update on the logic for locating the dotnet on the macOS hardware.
I'm not sure why some of the paths are hardcoded, but I did add a new path and loop over it instead of checking depending on the system.

If there is any extra logic needed on this, please let me know that I can update this for more use cases.

@RedworkDE
Copy link
Member

See also #74221

Did you test your change? I don't think that without the hostfxr_resolver.cpp change this fixes the issue.

@shinspiegel
Copy link
Author

See also #74221

Did you test your change? I don't think that without the hostfxr_resolver.cpp change this fixes the issue.

I was waiting for the build process to run on my local
(fresh new machine so it was a fresh build... and it takes time)

Didn't work. Looks like needs the other one to work, I was hopeful, but wasn't enough.
I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants