Organize 2D audio, camera, and physics in Viewport #79183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
e40c706
to
cf01e71
Compare
This was referenced Aug 10, 2023
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
cf01e71
to
1afc981
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
1afc981
to
5983fbe
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
5983fbe
to
efd581c
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
efd581c
to
8461aa7
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
8461aa7
to
4ae6512
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
4ae6512
to
e4a814b
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
e4a814b
to
6f8f378
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
6f8f378
to
be0da91
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
be0da91
to
00a8ea5
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
00a8ea5
to
1029512
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
1029512
to
2adbae5
Compare
aaronfranke
force-pushed
the
viewport-group-2d
branch
2 times, most recently
from
82808cb
to
3b193df
Compare
akien-mga
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Seems good to me conceptually.
I'll let @AThousandShips confirm her code review before merging, as I didn't review in depth myself.
AThousandShips
approved these changes
Mar 10, 2024
aaronfranke
force-pushed
the
viewport-group-2d
branch
from
3b193df
to
c1e9842
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR organizes the 2D audio listener, camera, and physics methods in Viewport to be close to each other, and put them right above the 3D methods.
In addition to the grouping those audio/camera/physics together, this also moves the 2D audio listener code together, since previously the audio listener methods were scattered in 3 different places.
This PR takes a piece out of #66744, split off for easy reviewing.
This PR is the 2D version of #51474.