Improve scene tiles workflow #80754
Merged
Improve scene tiles workflow #80754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
TileSetImprovementsCollectionSource
branch
from
c8376a8
to
a88e3b8
Compare
groud
reviewed
Aug 22, 2023
| @@ -398,6 +402,10 @@ void TileMapEditorTilesPlugin::_update_scenes_collection_view() { | |||
| scene_tiles_list->select(item_index, false); | |||
| } | |||
| } | |||
| if (scene_tiles_list->get_item_count() == 0) { | |||
| scene_tiles_list->add_item(TTR("The selected scene collection source has no scenes. Add scenes in the TileSet bottom tab.")); | |||
There was a problem hiding this comment.
This is a bit hacky TBH, message should likely be displayed with a Label. It's looks a bit weird you can hover/select such a message.
There was a problem hiding this comment.
It can't be selected. It's disabled.
There was a problem hiding this comment.
Yeah, but the hover effect is still a bit confusing about it IMO. It's not a big issue though, if you don't want to fix that right now I think the PR can be merged anyway.
There was a problem hiding this comment.
If it can be merged then please approve 🙃
groud
approved these changes
Aug 22, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc improvements to scene collection tiles editing, similar to my previous improvements.
godot.windows.editor.dev.x86_64_XeZI6hTFdY.mp4
XwxlPvzhxM.mp4