Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on pressing autoplay in sprite frames editor #91830

Merged
merged 1 commit into from
May 14, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented May 11, 2024

Fix #91826, I think the errors emits because the history changed but not for a correct object (SpriteFrames rather than AnimatedSprite itself), in other places it behaves correctly.

@Chaosus Chaosus force-pushed the fix_animation_history_bug branch from df63ec8 to b4dd2d0 Compare May 13, 2024 18:20
@Chaosus
Copy link
Member Author

Chaosus commented May 13, 2024

Also found/fix the same bug when renaming/removing the animation.

@Chaosus Chaosus force-pushed the fix_animation_history_bug branch 6 times, most recently from b4d955a to bd2aa72 Compare May 13, 2024 19:13
@Chaosus Chaosus force-pushed the fix_animation_history_bug branch from bd2aa72 to 56026e6 Compare May 13, 2024 19:39
@KoBeWi
Copy link
Member

KoBeWi commented May 13, 2024

The problem with rename is that it tries to modify both the resource and nodes. _rename_node_animation() should probably be undo operation itself, not the node changes. But it's something for another PR.

@akien-mga akien-mga merged commit 598be9b into godotengine:master May 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing "AutoPlay on Load" button of the sprite frames editor emit error to the output
4 participants