Fix "icon" parameter in EditorPlugin.add_custom_type is not optional but doc says it is #93777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, although it really should be optional, I don't see why it isn't. |
Mickeon
added
cherrypick:4.2
Mickeon
approved these changes
Jun 30, 2024
Mickeon
added
cherrypick:4.1
|
Please squash your commits into one, see here |
AThousandShips
approved these changes
Jun 30, 2024
… but docs says it is# This is a combination of 2 commits. Fix "icon" parameter in EditorPlugin.add_custom_type is not optional, but docs says it is Update doc/classes/EditorPlugin.xml Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Mickeon
approved these changes
Jun 30, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed an error in doc/classes/EditorPlugin.xml: "icon" parameter in EditorPlugin.add_custom_type is not optional, but documentation says it is.
Removed the line "An icon can be optionally passed." and added this "An editor error is generated when this function is called without the icon parameter."