Clarify that some exclude properties of physics query parameters are copied

[ayanchavand]

Fixes #93895

• Added the line Note that [code]exclude[/code] is a replace-don't-edit type property and can only be modified by replacing the entire array. to the PhysicsShapeQueryParameters3D.exclude docs

[AThousandShips]

This should probably be done to all the cases of this, both 2D and 3D as well as the other parameters such as point and ray queries

Edit: to clarify, I don't mean any case at all, but the physics classes, i.e.:

• PhysicsShapeQueryParameters2D
• PhysicsPointQueryParameters2D
• PhysicsPointQueryParameters3D
• PhysicsRayQueryParameters2D
• PhysicsRayQueryParameters3D

Including some that exclude objects by int

[Mickeon]

Your own PR does this but it is done for every Packed Array property. To handles Arrays like these would require a solution that allows properties to add the note automatically given a certain criteria.

[AThousandShips]

That would be pretty complex as there's no way to detect it, so it'd be a matter of adding a new property to the XML class, not sure it's worth it, but might look into checking how many cases there are for this

There's no way to detect this automatically, but we could add a hint or something to make the doc generation add it automatically to the XML, but I don't think it's common enough to justify it

[Mickeon]

Not this case specifically, but there are many times where information is repeated that may benefit from such a system, similar to the keywords.

[AThousandShips]

Absolutely, and I'll look at if there's enough cases to justify a system, but since this isn't automatable, and is likely not very common (i.e. cases that copy and aren't Packed*Arrays which require a different message), it might not be worth it, but I'll take a look at adding an option to manually tag with is_copied or something to make the output text automated

[AThousandShips]

Please add to the other cases mentioned to get this to cover all the related cases, then this should be ready!

[AThousandShips]

You also merged your branch instead of using a force push, please use git push --force instead, and when you're done please squash your commits into one, see here

[ayanchavand]

I think I accidentally created a branch from some other local branch instead of master, is it okay if I open new pr with the above changes?

[AThousandShips]

You can just rebase it, see the link, it shouldn't matter as long as you rebase on master

Also please make the final commit message something clear, like the PR title

[ayanchavand]

oh got it, thank you and sorry for the inconvenience

[AThousandShips]

No inconvenience at all! Part of what I'm here for is to help along!

[AThousandShips]

After fixing the incorrect line above please update the commit title (using git commit --amend), and you can remove the co-author it's not needed for suggestions

(The title still hasn't been changed, it should be "Clarify that some exclude properties of physics query parameters are copied" instead of "Added exculde's replace-don't-edit type property in docs")

[ayanchavand]

done

[akien-mga]

Thanks!