C#: Add IntersectsRay to Aabb
#97695
Conversation
Synthetic-Dev
changed the title
Aabb with CoreAabb
There was a problem hiding this comment.
Thanks for contributing to the .NET module! Looks like the code matches the Core implementation, and is consistent with the other Intersects* methods in Aabb. I'm making a few comments, mostly about code-style.
Also, since you are a new contributor, make sure to read CONTRIBUTING.md and the contributing documentation if you haven't already.
You'll need to squash the commits before this PR can be merged. The contributing documentation contains information about squashing in case you need it.
Feel free to reach out in the development chat if you need help.
| /// </returns> | ||
| public readonly bool IntersectsRay(Vector3 from, Vector3 dir) | ||
| { | ||
| if (HasPoint(from)) return true; |
There was a problem hiding this comment.
I don't see this in the Core implementation, and seems a bit redundant.
| if (HasPoint(from)) return true; | |
| if (HasPoint(from)) | |
| { | |
| return true; | |
| } |
There was a problem hiding this comment.
You're saying remove it? Seems like a potential optimisation to me but I may be wrong
There was a problem hiding this comment.
We'd have to benchmark it to see if makes a difference.
Co-authored-by: Raul Santos <raulsntos@gmail.com>
Co-authored-by: Raul Santos <raulsntos@gmail.com>
…odot into dotnet/sync-aabb
IntersectsRayintersects_rayimplementation without inside/normal/intersection point calculation