feat: Codegen for RPCs. rpc and rpc_id/rpcId now strongly typed.#205
Merged
Benjamin-Dobell merged 1 commit intogodotjs:mainfrom Apr 17, 2026
Merged
Conversation
Benjamin-Dobell
force-pushed
the
feat/rpc-codegen
branch
4 times, most recently
from
f62dfd5 to
12ac763
Compare
Also addressed some GC related crashes. Basically, V8 bans certain operations in the "first pass" of a GC finalizer callback. The first pass is supposed to be FAST. We have to explicitly request a second pass, which is where we can do more work (our own callbacks). Additionally, during isolate shutdown we should avoid making explicit GC calls and not make second pass requests.
Benjamin-Dobell
force-pushed
the
feat/rpc-codegen
branch
from
12ac763 to
020c302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen now generates types for RPC methods (methods annotated with
@bind.rpc) on Nodes.Also addressed some GC related crashes. Basically, V8 bans certain operations in the "first pass" of a GC finalizer callback. The first pass is supposed to be FAST. We have to explicitly request a second pass, which is where we can do more work (our own callbacks).
Additionally, during isolate shutdown we should avoid making explicit GC calls and not make second pass requests.