-
Notifications
You must be signed in to change notification settings - Fork 56
fix bug for Network file system #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please provide a unittests for this fix |
|
@ReneWerner87 I added test module. |
|
For keeping go version to 1.13 (following on README.md) |
ok thats fine for me |
|
@mingkyme can you do the last changes ? |
|
@ReneWerner87 I removed test codes for keeping go version. |
|
thx https://github.com/valyala/fasthttp/blob/7a5afddf5b805a022f8e81281c772c11600da2f4/client_timing_wait_test.go#L1-L2 think then they will be skipped in the old versions and we still have tests for the new embed feature |
|
I did. |
I fixed some bug for network file system.
It help to using embed library with import inner amber files.
for example
visit https://github.com/mingkyme/golang-embed-amber