Skip to content

Conversation

@mingkyme
Copy link
Contributor

I fixed some bug for network file system.

It help to using embed library with import inner amber files.

doctype
html
    head
    body
        import components/header
        h1 Hi
        h2 Hi Hi
        import components/footer

for example
visit https://github.com/mingkyme/golang-embed-amber

@ReneWerner87 ReneWerner87 added the ☢️ Bug Something isn't working label Nov 13, 2021
@ReneWerner87
Copy link
Member

Please provide a unittests for this fix

@mingkyme
Copy link
Contributor Author

@ReneWerner87 I added test module.

@mingkyme
Copy link
Contributor Author

For keeping go version to 1.13 (following on README.md)
Have to remove "embed" module.

@ReneWerner87
Copy link
Member

For keeping go version to 1.13 (following on README.md) Have to remove "embed" module.

ok thats fine for me

@ReneWerner87
Copy link
Member

@mingkyme can you do the last changes ?

@mingkyme
Copy link
Contributor Author

@ReneWerner87 I removed test codes for keeping go version.

@ReneWerner87
Copy link
Member

thx

https://github.com/valyala/fasthttp/blob/7a5afddf5b805a022f8e81281c772c11600da2f4/client_timing_wait_test.go#L1-L2
@mingkyme can you try one more thing for me ? move those tests you removed to a separate file and create this comment header above with the minimum version

think then they will be skipped in the old versions and we still have tests for the new embed feature

@mingkyme
Copy link
Contributor Author

I did.

@ReneWerner87 ReneWerner87 merged commit 256d79d into gofiber:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☢️ Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants