perf: content-hash based cache keys for CI compatibility#5
Merged
cmilesdev merged 1 commit intogoforj:cmilesdev/custom-loaderfrom Mar 29, 2026
Merged
Conversation
Replace mtime-based cache invalidation with content hashing: - artifact_cache: use SHA-256 of file content instead of ModTime - discovery_cache: use content hash for file matching, add WIRE_DISCOVERY_CACHE_DIR env var - Bump cache versions (artifact v4, discovery v4) This enables wire cache to work correctly in CI environments where file mtimes are not preserved across runs (e.g., S3 cache restore, git checkout). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Hey! Thanks for contributing. Main concern for this would be overhead introduced from doing content based hashing. Ran the benchmarks locally and didn't seem to make a substantial difference to cause any concern. There's a few cache knobs that I think we should unify base env vars on but I'm totally fine with that change as well. I'm glad the new loader changes has made quite a bit of difference for you. I imagine this was on some pubg services? |
cmilesdev
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace mtime-based cache invalidation with content hashing:
This enables wire cache to work correctly in CI environments where file mtimes are not preserved across runs (e.g., S3 cache restore, git checkout).