-
Notifications
You must be signed in to change notification settings - Fork 1
Setup for HMR #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Setup for HMR #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivek-gofynd
approved these changes
Jul 31, 2024
| @@ -1,17 +1,17 @@ | |||
| { | |||
| "name": "groot", | |||
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinalviranii keep name same as repo name
| const router = createRouter({ | ||
| history: createWebHistory(), | ||
| base: process.env.BASE_URL, | ||
| base: '/', |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this dynamic @jinalviranii
vivek-gofynd
added a commit
that referenced
this pull request
Jul 31, 2024
* Update vue3 bolilerplate * Update package json file * Test coverall * move yml file to src folder * Add path to lcov.info in yml file * Setup for HMR (#15) * Setup for HMR * HMR changes * Fix test case and env variable * ReadMe content changes * Fix test case CI/CD * Change src directory to web * Change src directory to web * Readme.md updated * Readme changes * Dockerfile added * coverall config updated * SQL lite session storage * Update jest config and yml file * Update fdk-extension-javascript version and readme * Update README.md * Update package.json --------- Co-authored-by: vivek-gofynd <vivekprajapati@fynd.com> Co-authored-by: vivek-gofynd <140066872+vivek-gofynd@users.noreply.github.com> * Vue hmr (#16) * Setup for HMR * HMR changes * Fix test case and env variable * ReadMe content changes * Fix test case CI/CD * Change src directory to web * Change src directory to web * Readme.md updated * Readme changes * Dockerfile added * coverall config updated * SQL lite session storage * Update jest config and yml file * Update fdk-extension-javascript version and readme * Update README.md * Update package.json * format changes * test cases fix * Files deleted * Test cases fixed * merge conflict fixes * gitignore db added * Product router removed --------- Co-authored-by: jinalviranii <jinalvirani@gofynd.com> Co-authored-by: vivek-gofynd <vivekprajapati@fynd.com> --------- Co-authored-by: vivek-gofynd <vivekprajapati@fynd.com> Co-authored-by: vivek-gofynd <140066872+vivek-gofynd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.