v0.26.12: core/ test coverage 73.9% → 85.5% (COV-004)#165
Merged
Conversation
…device poll (COV-004) core/ coverage: 73.9% → 85.5% (+11.6pp) - error_test.go: 10 error types, all Kind variants, Unwrap/errors.Is/errors.As chains - buffer_mapping_test.go: MapWaiter lifecycle, BeginMap states, MarkDestroyed, UnmapBuffer transitions, TryRegisterMappedRange overlap, concurrent Wait - device_poll_test.go: RegisterPendingMap, PollMaps resolution, free-list recycling
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Real unit + regression tests for core/ — coverage 73.9% → 85.5% (+11.6pp)
Not boilerplate — every test verifies actual behavior with meaningful assertions.
New test files (1912 LOC)
core/error_test.go(~600 LOC) — 10 error types: all Kind variants,Unwrap/errors.Is/errors.Aschains, error message content, empty label fallback, sentinel distinctnesscore/buffer_mapping_test.go(~500 LOC) — MapWaiter lifecycle (signal/wait/cancel/reset), BeginMap rejection states (destroyed/pending/mapped), alignment errors, range overflow, MarkDestroyed during pending, UnmapBuffer transitions, TryRegisterMappedRange overlap, concurrent Wait (5 goroutines)core/device_poll_test.go(~200 LOC) — RegisterPendingMap, PollMaps submission resolution, HasPendingMaps, MaxKnownSubmissionIndex, free-list recycling, submission index 0 immediate resolution, HalDeviceHandleTest plan
go test ./core/...— all pass, 85.5% coveragego test ./...— all passgolangci-lint run— 0 issues on all 3 platformsgofmt -l .— clean