Merged
Conversation
executeFullscreenBlit (memcpy) must be checked BEFORE executeSPIRVDraw. The SPIR-V interpreter interprets fragment shader per-pixel which is 100x slower than direct memcpy for textured quad blit. Before: 0.65 FPS (SPIR-V interpreter per 440K pixels) After: ~60 FPS (direct memcpy/swizzle)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Replace Value = any with 48-byte tagged struct: Tag + F[4]float32 + U[4]uint32 + Ref. Scalars/vectors stored inline, zero heap alloc for arithmetic ops. Fragment: 4→3 allocs (-25%), 490→438 ns (-11%). Vertex: stable at 9 allocs, ~1120 ns. Docs: mark SPIR-V interpreter as debugging/testing tool, not production. CHANGELOG, README, ARCHITECTURE updated.
kolkov
force-pushed
the
release/naga-0.17.11-tagged-union
branch
from
5c9a2f6 to
6d6a9f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dot(v)with wrong arg count) + BUG-DXIL-041 (fine.wgsl 100% valid)anyinterface boxing with 48-byte inline struct. Fragment -25% allocs, -11% ns/op.Test plan
go test ./...— all passgolangci-lint— 0 issuesgofmt— cleandot(diff)→ error, not SIGSEGV