feat(macos): software backend blit #163#187
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review: PR #187Thank you for applying all review fixes and rebasing onto All review fixes applied ✅
CI: macOS test crash (only blocker)The macOS CI runner is headless (no display, no Metal GPU). Windows and Ubuntu tests were Suggested fix: Check if the Metal framework file exists on disk before calling func (m *metal) Open(objc *objcReflect) (err error) {
// Skip Metal on headless CI / environments without GPU
if _, err := os.Stat(metalLibraryLocation); err != nil {
return fmt.Errorf("software.metal: framework not found: %w", err)
}
// ... existing code
}Or, if the framework exists but Code quality — verified claims
Action neededFix the headless macOS CI crash — this is the only blocker. Once |
|
thanks for your review! I've fixed my code. Please check it when you have a moment. 🙏 |
kolkov
left a comment
There was a problem hiding this comment.
LGTM! All review fixes applied, CI 11/11 green. Great contribution.
resolve #163
Rebased onto
origin/mainbygit rebase origin/main.I confirmed renders triangle correctly in
gogpu/examples/triangle(GOGPU_GRAPHICS_API=software)