v0.28.5: Metal defer pool.Drain + drawable count + indirect validation nil guard#190
Merged
Conversation
errcheck: check DataProviderRelease/ImageRelease/SetDevice returns. nestif: restructure init() with early return. revive: eliminate 10 redundant if-return patterns. staticcheck: use embedded field directly (s.objc not s.platformBlit.objc). unconvert: remove 13 unnecessary unsafe.Pointer() wrappings. unused: remove cifMetalRegionMake2D, unused objc fields. 0 lint issues on Windows + Linux + macOS.
…alidation nil guard Metal: - Queue.Present(): defer pool.Drain() prevents autorelease leak on panic (Rust uses closure-scoped autoreleasepool for same guarantee) - Surface.Configure(): setMaximumDrawableCount:3 (Rust wgpu parity, surface.rs:176 — maximum_frame_latency + 1) Core: - indirect_validation: skip init when MaxComputeWorkgroupSizeX=0 (noop/test backends). Rust checks DownlevelFlags::INDIRECT_EXECUTION. - nil guard on dstBuffer/paramsBuffer before NativeHandle() call. Closes #189.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All verified against Rust wgpu-hal Metal reference.
Test plan
go build ./...— Windows, Linux, macOSgo test ./...— all passgolangci-lint run --timeout=5m— 0 issues