Fix compatibility with Rails delegated_type#3
Merged
nerlichman merged 2 commits intomainfrom Mar 14, 2026
Merged
Conversation
belongs_to accepts an optional scope as the second argument. safe_polymorphic was not forwarding this argument correctly, causing an ArgumentError when used with APIs like delegated_type.
nerlichman
reviewed
Mar 13, 2026
Contributor
nerlichman
left a comment
nerlichman
left a comment
There was a problem hiding this comment.
Instead of adding 3 new models, could we create just one new model that defines delegated_type to some of the other existing models?
Doesn't seem necessary to actually create House and Office.
nerlichman
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
belongs_to accepts an optional scope as the second argument. safe_polymorphic was not forwarding this argument correctly, causing an ArgumentError when used with APIs like delegated_type.