Fix #3321: commit tag shortener #3418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func ShortSha(sha1 string) string { | ||
| if len(sha1) == 40 { |
Member
There was a problem hiding this comment.
We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to if len() > 10, then cut.
Contributor
Author
There was a problem hiding this comment.
I have done this to always have uniform short tag on all pages regardless of what users use (7-char, 8-char, ..., 40-char commit SHA).
Ok if you want remove this; I will do needed modifications tonight.
Member
There was a problem hiding this comment.
Yes, please do the modification, we still want to show 10-char on the UI. Thought people could just use 7-char in other cases.
Member
|
Thanks! |
6 tasks
ethantkoenig
added a commit
to ethantkoenig/gogs
that referenced
this pull request
Feb 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short commit references now working with a 7 to 40 SHA length' (Issue #3321) and base.ShortSha() function has been modified to uniformize short SHA's representation (length: 7).