js: use safe DOM construction for milestone and assignee selection#8178
Merged
js: use safe DOM construction for milestone and assignee selection#8178
Conversation
…8178) Use jQuery DOM APIs (.text(), .attr(), createTextNode) instead of string concatenation with .html() to prevent user-controlled text from being reinterpreted as HTML. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses a DOM-based XSS vulnerability by replacing unsafe string concatenation with jQuery's safe DOM construction APIs when rendering milestone and assignee selections on the issue page.
Changes:
- Replaced
.html()with string concatenation using safe jQuery methods (.text(),.attr(),createTextNode) for milestone selection - Applied the same safe DOM construction pattern for assignee selection including avatar images
- Added security fix entry to CHANGELOG.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| public/js/gogs.js | Refactored milestone and assignee selection to use safe DOM construction methods instead of string concatenation |
| CHANGELOG.md | Documented the security fix for DOM-based XSS vulnerability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.text(),.attr(),createTextNode) instead of string concatenation with.html()to prevent user-controlled text from being reinterpreted as HTML during milestone and assignee selection on the issue page.Security