Skip to content

security: require POST for org team and member actions#8321

Merged
unknwon merged 3 commits into
mainfrom
ghsa-pwx3-qcgw-vh7h
Jun 5, 2026
Merged

security: require POST for org team and member actions#8321
unknwon merged 3 commits into
mainfrom
ghsa-pwx3-qcgw-vh7h

Conversation

@unknwon

@unknwon unknwon commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

Organization team and member management routes accepted GET requests, allowing state-changing operations (add, remove, leave, join, public/private toggle) to be triggered via top-level navigation. A logged-in organization owner could be tricked into following a crafted link that added an attacker to the Owners team. These endpoints now require POST, and the corresponding templates submit POST forms instead of issuing GET requests via <a href>.

Fixes GHSA-pwx3-qcgw-vh7h.

Test plan

  • As an org owner, leave/join/remove a team via the team and teams pages
  • As an org owner, add and remove members on a team page
  • As an org owner, add and remove repositories on a team page
  • Toggle membership visibility (public/private) on the members page
  • Confirm that issuing the same actions via a GET request returns 404

unknwon added 2 commits June 4, 2026 10:47
The team and member action endpoints accepted GET, so a logged-in org
owner who followed a crafted link could be made to add an attacker to
the Owners team without any further interaction. These routes are now
POST-only, and the templates that triggered them via <a href> have been
converted to inline POST forms.
@unknwon unknwon added this to the 0.14.3 milestone Jun 4, 2026
@unknwon unknwon merged commit 070df61 into main Jun 5, 2026
8 checks passed
@unknwon unknwon deleted the ghsa-pwx3-qcgw-vh7h branch June 5, 2026 12:05
unknwon added a commit that referenced this pull request Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant