Skip to content

Proposal: Pluggable Image Vulnerability Scanning#98

Merged
steven-zou merged 18 commits intogoharbor:masterfrom
danielpacak:pluggable_image_vulnerability_scanning
Oct 18, 2019
Merged

Proposal: Pluggable Image Vulnerability Scanning#98
steven-zou merged 18 commits intogoharbor:masterfrom
danielpacak:pluggable_image_vulnerability_scanning

Conversation

@danielpacak
Copy link
Copy Markdown
Contributor

@danielpacak danielpacak commented Jul 31, 2019

This is a combination of #82 and #90 and PRD by Alex Xu.

The main file to read is proposals/pluggable-image-vulnerability-scanning_proposal.md.

@steven-zou steven-zou added kind/proposal area/interrogation-service Services like vulnerability scanning and compliance checking etc. labels Aug 5, 2019
@danielpacak danielpacak marked this pull request as ready for review August 7, 2019 19:47
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Copy link
Copy Markdown

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress!

Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md Outdated
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
@xaleeks xaleeks self-requested a review August 8, 2019 12:46
Comment thread proposals/pluggable-image-vulnerability-scanning_proposal.md
steven-zou
steven-zou previously approved these changes Oct 16, 2019
Copy link
Copy Markdown
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmpei
mmpei previously approved these changes Oct 16, 2019
Copy link
Copy Markdown
Contributor

@mmpei mmpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kofj
kofj previously approved these changes Oct 16, 2019
…n ScanRequest

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak dismissed stale reviews from kofj, mmpei, and steven-zou via 61475b6 October 16, 2019 14:03
Copy link
Copy Markdown
Contributor

@steven-zou steven-zou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-zou
Copy link
Copy Markdown
Contributor

steven-zou commented Oct 18, 2019

Hello, @goharbor/all-maintainers @lizrice @michmike @danfengliu @zhill

As we have got enough votes (4/5) now, this proposal is accepted and will be merged now. Thank you all for drafting, reviewing and voting!

@steven-zou steven-zou merged commit d394632 into goharbor:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/interrogation-service Services like vulnerability scanning and compliance checking etc. kind/proposal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants