Skip to content

Add '--force' flag to delete non-empty projects#252

Merged
Vad1mo merged 2 commits intogoharbor:mainfrom
adwait-godbole:add-force-flag
Nov 26, 2024
Merged

Add '--force' flag to delete non-empty projects#252
Vad1mo merged 2 commits intogoharbor:mainfrom
adwait-godbole:add-force-flag

Conversation

@adwait-godbole
Copy link
Copy Markdown
Contributor

@adwait-godbole adwait-godbole commented Nov 14, 2024

Fixes #243

Screencast.from.2024-11-14.17-03-59.webm

Hi @Vad1mo @bupd, I tried fixing the problem and it is working fine on my machine as you can see in the above video. Let me know if any improvements should be done to do this approach as it is my very first time contributing to Harbor. Thanks for this amazing project!

@adwait-godbole
Copy link
Copy Markdown
Contributor Author

adwait-godbole commented Nov 14, 2024

@Vad1mo thanks for enabling the CI on my PR. I have got the same failure when I was trying to publish a draft release on my fork over here following the documentation giving in RELEASE.md. I am not sure what is causing "Run Tests" to fail. Could you please help me by pointing out what am I doing wrong? Thanks.

@Vad1mo
Copy link
Copy Markdown
Member

Vad1mo commented Nov 14, 2024

@adwait-godbole can you rebase your changes on latest main? I think then the tests should work

Signed-off-by: adwait-godbole <adwaitngodbole@gmail.com>
@adwait-godbole
Copy link
Copy Markdown
Contributor Author

@adwait-godbole can you rebase your changes on latest main? I think then the tests should work

@Vad1mo I have done the rebase but I guess your approval is again required for triggering the workflow. Also when I drafted a test release on my fork, the triggered workflow still failed during the "Run Tests" job --> https://github.com/adwait-godbole/harbor-cli/actions/runs/11851195614.

@adwait-godbole
Copy link
Copy Markdown
Contributor Author

@bupd can you please review this one as well. I think the issue you have pointed out at #249 might be the reason that the tests are failing. Am I correct? Or is it something else?

@bupd bupd self-requested a review November 21, 2024 08:41
Signed-off-by: Vadim Bauer <vb@container-registry.com>
Copy link
Copy Markdown
Collaborator

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vad1mo Vad1mo merged commit 5bbf322 into goharbor:main Nov 26, 2024
qcserestipy pushed a commit to qcserestipy/harbor-cli that referenced this pull request Dec 22, 2024
Signed-off-by: adwait-godbole <adwaitngodbole@gmail.com>
Signed-off-by: Vadim Bauer <vb@container-registry.com>
Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Patrick Eschenbach <patrickeschenbach96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force deletes non empty projects

3 participants