Skip to content

Showing the name in table format for artifact tags list cmd#286

Closed
Althaf66 wants to merge 1 commit intogoharbor:mainfrom
Althaf66:artifacttaglist
Closed

Showing the name in table format for artifact tags list cmd#286
Althaf66 wants to merge 1 commit intogoharbor:mainfrom
Althaf66:artifacttaglist

Conversation

@Althaf66
Copy link
Copy Markdown
Contributor

This PR fixes #256

Due to DCO failure, I created PR for the #257

Before
Screenshot from 2024-11-15 00-34-53

After
harbor artifact tags list
Screenshot from 2024-11-15 00-54-00

And changed to 'project/repo@digest' format

Signed-off-by: ALTHAF <althafasharaf02@gmail.com>
@Althaf66 Althaf66 changed the title changes in artifact tags list cmd Showing the name in table format for artifact tags list cmd Dec 17, 2024
Copy link
Copy Markdown
Collaborator

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shows empty for every artifacts??

We get data in json format. Please update the table to fix this.

❯ ./harbor-dev artifact list
┌───────────────────────────────────────────────────────────────────────────────────────────┐
│  ID      Artifact Digest       Type          Size          Vulnerabilities  Push Time     │
│ ───────────────────────────────────────────────────────────────────────────────────────── │
│                                                                                           │
└───────────────────────────────────────────────────────────────────────────────────────────┘

@bupd
Copy link
Copy Markdown
Collaborator

bupd commented Feb 5, 2025

merge conflicts!! && wait for #300 before merging

@bupd
Copy link
Copy Markdown
Collaborator

bupd commented Mar 15, 2025

merge conflicts!

@bupd bupd added the help wanted Extra attention is needed label Mar 15, 2025
@rizul2108
Copy link
Copy Markdown
Collaborator

@bupd do i need to contiue work on this PR?
currently artifact tags list command shows like below:
image
ID is not shown in table should I work on this PR further to get that merged or I can make a new PR by myself for adding ID in the table ?

@bupd
Copy link
Copy Markdown
Collaborator

bupd commented Apr 3, 2025

Yes, those Merge conflicts need to be fixed.

@rizul2108
Copy link
Copy Markdown
Collaborator

Can i not rather make new PR just for adding ID to the table as all other details are showing already in the table?

@bupd
Copy link
Copy Markdown
Collaborator

bupd commented Apr 4, 2025

sure go ahead

@rizul2108
Copy link
Copy Markdown
Collaborator

@bupd This PR can be closed as the same work has been done in PR #241 and the changes required in this PR are properly implemented and running in main branch

@bupd bupd closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Showing pointer value for tag list cmd

3 participants