Fix Redis URL formatting in Harbor Helm chart#2153
Closed
Eyalm321 wants to merge 2 commits intogoharbor:mainfrom
Closed
Fix Redis URL formatting in Harbor Helm chart#2153Eyalm321 wants to merge 2 commits intogoharbor:mainfrom
Eyalm321 wants to merge 2 commits intogoharbor:mainfrom
Conversation
Signed-off-by: eyalm321 <emizrachi321@gmail.com>
Signed-off-by: eyalm321 <emizrachi321@gmail.com>
Author
|
It might need some adjustment for tls. I couldnt get it to work eventually with redis |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
|
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Redis url templating issues for external redis kubernetes deployment. It wont recognize redis.cache.svc.cluster.local as a number anymore.
I havent done implementation for redis.external.host and redis.external.port since Ive seen it only on online goharbor helm chart and not actual implementation. let me know if you want that in there.