feat: make health probe timeoutSeconds and failureThreshold configurable via values#2317
Open
lindeskar wants to merge 1 commit intogoharbor:mainfrom
Open
feat: make health probe timeoutSeconds and failureThreshold configurable via values#2317lindeskar wants to merge 1 commit intogoharbor:mainfrom
lindeskar wants to merge 1 commit intogoharbor:mainfrom
Conversation
lindeskar
force-pushed
the
probe-timeouts
branch
from
b84073f to
d0860c6
Compare
…ble via values Expose all five probe timing parameters (initialDelaySeconds, periodSeconds, timeoutSeconds, failureThreshold, successThreshold) as configurable values for all components: core, portal, jobservice, registry, nginx, exporter, trivy, database, and redis. Defaults match the current hardcoded values exactly, so there is zero behavioral change on upgrade. Closes goharbor#2316 Signed-off-by: Alexander Lindeskär <lindeskar@users.noreply.github.com>
lindeskar
force-pushed
the
probe-timeouts
branch
from
d0860c6 to
c2402f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialDelaySeconds,periodSeconds,timeoutSeconds,failureThreshold,successThreshold) as configurable values for all 9 components: core, portal, jobservice, registry (registry + registryctl), nginx, exporter, trivy, database, and redisCloses #2316
Motivation
Health probe settings are currently hardcoded in templates and cannot be overridden via
values.yaml. This causes issues in environments with higher network latency (e.g. China regions), where the default 1s timeout and low failure thresholds trigger unnecessary pod restarts and 502 errors.Test plan
helm templatebefore/after diff shows only newly-explicit fields (timeoutSeconds, failureThreshold, successThreshold) that were previously Kubernetes implicit defaults — no behavioral changehelm unittest -f 'test/unittest/**/*_test.yaml' .)helm template . --set core.livenessProbe.timeoutSeconds=5 --set core.livenessProbe.failureThreshold=5renders custom values correctly🤖 Generated with Claude Code