-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Description
Is your feature request related to a problem? Please describe.
Problem
I'm regularly getting out of memory alerts from our monitoring system. This relates to Trivy running in Harbor against some specific images. In reality this is because our devs are uploading LLMs inside image so that they can be served to customers - this is not something we can change but we may be able to work around it with a new flag available in Trivy.
Describe the solution you'd like
One solution would be for me to throw one of our 2TB memory capable machines at harbor and let it rip! But in reality, the code bases for the image in question is scanned before the image is built so this seems a waste of a machine and also a pointless venture.
What would be even better is if we could make use of the new experimental feature flag introduced in 0.59.0 - docs.
I suspect this change would likely be required in the harbor-scanner-trivy repo (in which issues are apparently turned off, I guess they should be raised here?) with some flags able to be configured from Harbor itself.
As I'm using Helm to deploy Harbor, it's likely a change would be required in there too which allows us to configure the environment variables in the StatefulSet via the relevant section in the values.yaml.
I'd love to have a crack at this but I'll be frank and say I haven't got time right now to look into how to implement this as it's not a simple case of updating harbor to pass specific flags via envvars to Trivy. If it was I'd be all over it!
I was looking at this PR for inspiration but I feel like more is required than a few config adjustments. Please let me know if I'm wrong and by all means I'll have a look as soon as it's feasibly possible for me to do so.