feature(tag) add a thread pool size for tags list #13168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziming Zhang <zziming@vmware.com>
bitsf
force-pushed
the
limit_pool_tag_list
branch
from
48603b3 to
093c1b4
Compare
Pull Request Test Coverage Report for Build 19193
💛 - Coveralls |
Contributor
|
Could you also check the setting on redis to understand the limit? it may be a bottleneck for pulling images concurrently. |
steven-zou
reviewed
Oct 20, 2020
heww
approved these changes
Nov 2, 2020
ywk253100
reviewed
Nov 2, 2020
| tag, | ||
| config.WithNotary(), | ||
| signatures, | ||
| limit, |
Contributor
There was a problem hiding this comment.
Just a minor suggestion, is it better to get the true from limit before starting a goroutine? In this way only 100 goroutines will be created
ywk253100
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13098
add a thread pool size for tags list, in case it takes up too much resources