This repository was archived by the owner on Dec 7, 2019. It is now read-only.
Add configurable ADB commands timeout. Fixes #7. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-zinnatullin
approved these changes
Nov 5, 2017
| fun AdbDevice.log(message: String) = com.gojuno.commander.os.log("[$id] $message") | ||
|
|
||
| fun AdbDevice.installApk(pathToApk: String): Observable<Unit> { | ||
| fun AdbDevice.installApk(pathToApk: String, timeout: Pair<Int, TimeUnit> = 5 to MINUTES): Observable<Unit> { |
Contributor
There was a problem hiding this comment.
Let's reduce default to 2 minutes, sounds reasonable?
Contributor
Author
There was a problem hiding this comment.
OK.
Both composer and commander are before version 1.0.0 so I assume that it is acceptable that users which currently need timeout between 2 and 5 minutes will have to adjust their configurations.
Contributor
There was a problem hiding this comment.
yep, that's the rationale, once we get to 1.x will strictly follow semantic versioning!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is merged I'll fill PR in Composer.