This repository was archived by the owner on Dec 7, 2019. It is now read-only.
Add user-friendly error message for "Unable to find instrumentation info".#88
Merged
arturdryomov merged 2 commits intomasterfrom Jul 26, 2017
Merged
Conversation
dmitry-novikov
approved these changes
Jul 26, 2017
dmitry-novikov
suggested changes
Jul 26, 2017
Contributor
dmitry-novikov
left a comment
dmitry-novikov
left a comment
There was a problem hiding this comment.
For some reason your test is not working on CI.
Collaborator
Author
|
Interesting, they pass for me locally (macOS, Docker 17.06.1-ce-rc1-mac20 (18682)): |
Contributor
|
Failed on my Arch Linux: |
Collaborator
Author
|
hmm, what is the line of source code that causes it? For some reason JUnit5 does not print that atm |
Contributor
|
@artem-zinnatullin, did you forget to commit |
Collaborator
Author
|
Holy shit, it was broken |
| npm-debug.log* | ||
| test/ | ||
| composer/src/main/resources/html-report/ | ||
| /test/ |
Collaborator
Author
There was a problem hiding this comment.
This ignored all test folders, even subfolders
dmitry-novikov
approved these changes
Jul 26, 2017
yunikkk
approved these changes
Jul 26, 2017
Collaborator
Author
|
I don't have rights to merge PRs, feel free to do it
…On Wed, Jul 26, 2017, 01:43 Dmitry Yunitsky ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA7B3LZfEFar0khCF3yOtXaXVAtd3ob0ks5sRvwugaJpZM4OjYZB>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help users resolve the issue much more quickly rather than staring at weird
NumberFormatException.See #79.